Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cdc and wal2json and use the default postgres entrypoint #3260

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

beezz
Copy link
Contributor

@beezz beezz commented Aug 12, 2024

CDC and wal2json in no longer used and has been removed in prod long time ago. This PR attempts to remove all the traces of cdc and wal2json from self-hosted setup possibly using the default postgresql docker entrypoint .

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (053f401) to head (f1842b3).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3260   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files           3        3           
  Lines         203      203           
=======================================
  Hits          201      201           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BYK
Copy link
Member

BYK commented Aug 12, 2024

Yes, thanks for doing this!

Not sure if you were able to dig it out yourself but here's when all this stuff was introduced: #938.

Looks like we need a removal from the .env and .gitignore files too?

Oh, and the init_hba file

@beezz
Copy link
Contributor Author

beezz commented Aug 12, 2024

Yes, thanks for doing this!

Not sure if you were able to dig it out yourself but here's when all this stuff was introduced: #938.

Looks like we need a removal from the .env and .gitignore files too?

Oh, and the init_hba file

Thanks for quick response! I removed the last bits 👍

@BYK
Copy link
Member

BYK commented Aug 12, 2024

Error response from daemon: invalid mount config for type "bind": bind source path does not exist: /home/runner/work/self-hosted/self-hosted/self-hosted/postgres
Error in install/set-up-and-migrate-database.sh:4.

Hmm, let's see why that is

@BYK
Copy link
Member

BYK commented Aug 12, 2024

Looks like this needs to go too:

volumes:
- "sentry-postgres:/var/lib/postgresql/data"
- type: bind
read_only: true
source: ./postgres/
target: /opt/sentry/

@beezz
Copy link
Contributor Author

beezz commented Aug 12, 2024

Looks like this needs to go too:

volumes:
- "sentry-postgres:/var/lib/postgresql/data"
- type: bind
read_only: true
source: ./postgres/
target: /opt/sentry/

oh, thanks! Removed the read only bind as well now.

@BYK
Copy link
Member

BYK commented Aug 12, 2024

Aaan we have the greens! @hubertdeng123 stampy stampy please

@hubertdeng123 hubertdeng123 merged commit 534a874 into master Aug 12, 2024
14 checks passed
@hubertdeng123 hubertdeng123 deleted the ref/remove-cdc-wal2json branch August 12, 2024 16:12
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants