-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cdc and wal2json and use the default postgres entrypoint #3260
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3260 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 3 3
Lines 203 203
=======================================
Hits 201 201
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Yes, thanks for doing this! Not sure if you were able to dig it out yourself but here's when all this stuff was introduced: #938. Looks like we need a removal from the Oh, and the |
Thanks for quick response! I removed the last bits 👍 |
Hmm, let's see why that is |
Looks like this needs to go too: self-hosted/docker-compose.yml Lines 140 to 145 in 053f401
|
oh, thanks! Removed the read only bind as well now. |
Aaan we have the greens! @hubertdeng123 stampy stampy please |
CDC and wal2json in no longer used and has been removed in prod long time ago. This PR attempts to remove all the traces of cdc and wal2json from self-hosted setup possibly using the default postgresql docker entrypoint .
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.