Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Skip DB ops during install completely on cache hit #3496

Merged
merged 10 commits into from
Dec 31, 2024

Conversation

BYK
Copy link
Member

@BYK BYK commented Dec 31, 2024

Follow up to #3488

A new record: 2m 8s for installing self-hosted:
image

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (8653327) to head (c7433fb).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3496   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files           3        3           
  Lines         207      207           
=======================================
  Hits          203      203           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BYK BYK requested a review from hubertdeng123 December 31, 2024 11:34
@BYK BYK marked this pull request as ready for review December 31, 2024 11:34
@BYK BYK enabled auto-merge (squash) December 31, 2024 11:34
@BYK
Copy link
Member Author

BYK commented Dec 31, 2024

@aldy505 @aminvakil 👋🏻

@BYK BYK mentioned this pull request Dec 31, 2024
3 tasks
@BYK BYK merged commit 8c1653d into master Dec 31, 2024
14 checks passed
@BYK BYK deleted the byk/ci/skip-db-completely-on-cache branch December 31, 2024 21:26
Copy link
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I've been late to the party, LGTM, thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants