Bundle Java Sources and upload to Sentry #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adinauer
commented
Apr 19, 2023
plugin-build/src/main/kotlin/io/sentry/android/gradle/AndroidComponentsConfig.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/AndroidComponentsConfig.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/AndroidComponentsConfig.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/AppConfig.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/extensions/SentryPluginExtension.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/sourcecontext/BundleSourcesTask.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/sourcecontext/BundleSourcesTask.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/sourcecontext/CollectSourcesTask.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/sourcecontext/SourceContext.kt
Show resolved
Hide resolved
adinauer
commented
Apr 19, 2023
plugin-build/src/main/kotlin/io/sentry/android/gradle/AndroidComponentsConfig.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/AppConfig.kt
Outdated
Show resolved
Hide resolved
romtsn
reviewed
May 3, 2023
plugin-build/src/main/kotlin/io/sentry/android/gradle/extensions/SentryPluginExtension.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/sourcecontext/OutputPaths.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/sourcecontext/GenerateBundleIdTask.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/sourcecontext/BundleSourcesTask.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/sourcecontext/BundleSourcesTask.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/AppConfig.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/AppConfig.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/AndroidComponentsConfig.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/AndroidComponentsConfig.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/AndroidComponentsConfig.kt
Outdated
Show resolved
Hide resolved
- Use `Properties` class instead of writing strings to files and reading + manually parsing (also for previously existing tasks) - Add changelog - Add `debug` option to extension to enable debug log output of sentry-cli - Add org and project inputs to tasks using sentry-cli - Don't use outputDir for debug meta properties task - Get source files from variant lazily - Only hook into assemble for build type "release" - Turn `includeSourceBundle` off by default - Remove task.dependsOn as using input implicitly does that - Instead of removing 3 dirs from relative path of source dirs strip provided dir absolute path from beginning of all file paths contained in that dir when copying - Remove printlns (some were replaced by log statements) - Use different build dirs - Remove unused write bundle id to manifest task
- Make debug task input optional (default=false) - Remove some log output
…rces; track source context feature
…as input for collecting sources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Bundle and upload source code to Sentry, see issue linked below for more details on how this works.
💡 Motivation and Context
Android part of getsentry/sentry-java#633 for backend we'll first have to do some changes to SAGP to make it backend friendly.
💚 How did you test it?
manually; still need to add automated tests
📝 Checklist
🔮 Next steps