Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source context with configuration cache on AGP 8+ #725

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jun 20, 2024

📜 Description

Looks like Gradle has a bug where it queries values of providers using .zip or .flatMap too early, but using .map works, so we just use that + .get() for other providers (which will be still evaluated lazily since it's inside .map I believe)

💡 Motivation and Context

Closes #683

💚 How did you test it?

See updated integration test in the diff

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@romtsn romtsn merged commit bf1acca into main Jun 21, 2024
18 checks passed
@romtsn romtsn deleted the rz/fix/source-context-buildconfig-agp8 branch June 21, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration Cache Incompatibility
2 participants