Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

workaround android_id #185

Merged
merged 3 commits into from
Dec 5, 2019
Merged

workaround android_id #185

merged 3 commits into from
Dec 5, 2019

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Dec 5, 2019

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

generating android_id if Settings.Secure.ANDROID_ID is buggy or non existent.

💡 Motivation and Context

https://android-developers.googleblog.com/2011/03/identifying-app-installations.html

💚 How did you test it?

debugging all the cases, this class has not been tested yet (unit tests), will do it later on.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@codecov-io
Copy link

codecov-io commented Dec 5, 2019

Codecov Report

Merging #185 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #185   +/-   ##
=========================================
  Coverage     58.08%   58.08%           
  Complexity      551      551           
=========================================
  Files            73       73           
  Lines          2617     2617           
  Branches        233      233           
=========================================
  Hits           1520     1520           
  Misses          978      978           
  Partials        119      119

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db86d06...ecfa588. Read the comment docs.

@bruno-garcia bruno-garcia merged commit 3798b14 into master Dec 5, 2019
@bruno-garcia bruno-garcia deleted the bug/android_id branch December 5, 2019 21:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants