Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

implemented diagnostic logger #218

Merged
merged 1 commit into from
Jan 13, 2020
Merged

implemented diagnostic logger #218

merged 1 commit into from
Jan 13, 2020

Conversation

marandaneto
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

implement diagnostic logger with custom level.

💡 Motivation and Context

right now it's not respecting custom level nor if debug is enabled or not.

💚 How did you test it?

running current tests and debugging it.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

Comment on lines +123 to +124
// TODO: check how to assert IllegalArgumentException if param is @NotNull and you are calling from kotlin
assertFailsWith<KotlinNullPointerException> { fixture.getSut() }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to check this

@codecov-io
Copy link

codecov-io commented Jan 13, 2020

Codecov Report

Merging #218 into master will increase coverage by 0.17%.
The diff coverage is 49.59%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #218      +/-   ##
============================================
+ Coverage     58.91%   59.08%   +0.17%     
+ Complexity      572      569       -3     
============================================
  Files            73       72       -1     
  Lines          2648     2652       +4     
  Branches        235      235              
============================================
+ Hits           1560     1567       +7     
  Misses          970      970              
+ Partials        118      115       -3
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/sentry/core/MainEventProcessor.java 74.28% <100%> (+0.75%) 8 <0> (ø) ⬇️
...src/main/java/io/sentry/core/DiagnosticLogger.java 72.22% <100%> (ø) 11 <1> (ø) ⬇️
.../src/main/java/io/sentry/core/cache/DiskCache.java 51.42% <23.33%> (-2.31%) 12 <0> (ø)
...re/src/main/java/io/sentry/core/SentryOptions.java 78.22% <25%> (-1.62%) 55 <4> (ø)
...java/io/sentry/core/transport/AsyncConnection.java 58.33% <29.41%> (-1.91%) 5 <0> (ø)
...n/java/io/sentry/core/transport/HttpTransport.java 58.02% <30.76%> (-0.95%) 6 <0> (ø)
.../src/main/java/io/sentry/core/SendCachedEvent.java 60.34% <40%> (-0.68%) 6 <0> (ø)
sentry-core/src/main/java/io/sentry/core/Hub.java 70.44% <54.45%> (+3.08%) 55 <0> (ø) ⬇️
.../core/SendCachedEventFireAndForgetIntegration.java 78.57% <63.63%> (+0.79%) 4 <0> (ø) ⬇️
...e/src/main/java/io/sentry/core/EnvelopeSender.java 61.72% <66.66%> (ø) 7 <0> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 360099e...0095f44. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@marandaneto marandaneto merged commit 752a855 into master Jan 13, 2020
@marandaneto marandaneto deleted the ref/diagnostic_logger branch January 13, 2020 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants