-
-
Notifications
You must be signed in to change notification settings - Fork 32
added a few java docs (Sentry, Hub and SentryClient) #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bruno-garcia do we need to javadocs the Impl. classes or only the public interfaces?
@marandaneto Ideally all public types their members. I'd say at least all public API from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
CI is unhappy somehow
because of #224 already fixed it |
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
=========================================
Coverage ? 58.17%
Complexity ? 570
=========================================
Files ? 72
Lines ? 2697
Branches ? 238
=========================================
Hits ? 1569
Misses ? 1014
Partials ? 114
Continue to review full report at Codecov.
|
📢 Type of change
📜 Description
added a few java docs.
💡 Motivation and Context
we are poor of javadocs.
💚 How did you test it?
📝 Checklist
🔮 Next steps
more and more javadocs