Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

new Release format #242

Merged
merged 1 commit into from
Jan 27, 2020
Merged

new Release format #242

merged 1 commit into from
Jan 27, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jan 21, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

release now is health compat:
package@versionName+versionCode
eg: io.sentry.test@1.0.0+202001211

💡 Motivation and Context

We want to send the new release format to be compatible with Health.

💚 How did you test it?

debugging it, constants are code generated, not worth to mock it.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@bruno-garcia
Copy link
Member

Just to clarify this is not exactly semver. the semver bits are in it though

@bruno-garcia
Copy link
Member

@mitsuhiko might want to peek since the version format proposal is his

@marandaneto marandaneto changed the title release now is semver compat new Release format Jan 22, 2020
@marandaneto
Copy link
Contributor Author

Just to clarify this is not exactly semver. the semver bits are in it though

true, I've updated its title and desc.

@marandaneto marandaneto merged commit f01ab69 into master Jan 27, 2020
@marandaneto marandaneto deleted the enha/sem_ver branch January 27, 2020 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants