Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

fixes #259 - NPE check on getExternalFilesDirs items. #260

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

marandaneto
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

fixes #259 - NPE check on getExternalFilesDirs items.

💡 Motivation and Context

https://developer.android.com/reference/android/content/Context.html#getExternalFilesDirs(java.lang.String)

the absolute paths to application-specific directories. Some individual paths may be null if that shared storage is not currently available. The first path returned is the same as getExternalFilesDir(java.lang.String).

💚 How did you test it?

Ran on Nexus 5X API 21 emulator.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@marandaneto marandaneto merged commit 291414a into master Feb 4, 2020
@marandaneto marandaneto deleted the fix/null_file branch February 4, 2020 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants