This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 32
fix: breacrumb.data to string,object, Add LOG level #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
=========================================
Coverage ? 57.28%
Complexity ? 577
=========================================
Files ? 73
Lines ? 2774
Branches ? 235
=========================================
Hits ? 1589
Misses ? 1068
Partials ? 117
Continue to review full report at Codecov.
|
marandaneto
approved these changes
Feb 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bruno-garcia
suggested changes
Feb 11, 2020
…/sentry-android into fix/breadcrumbs-data-log-level
…/sentry-android into fix/breadcrumbs-data-log-level
sentry-android-core/src/main/java/io/sentry/android/core/AndroidLogger.java
Show resolved
Hide resolved
bruno-garcia
approved these changes
Feb 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Add fix that breadcrumb.data is
<String, Object>
instead of<String, String>
Add
LOG
as log level.💡 Motivation and Context
Support for Hybrid SDKs
💚 How did you test it?
unit test.
📝 Checklist
🔮 Next steps
🚢