This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
ANR report should have 'was active=yes' on the dashboard #299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
if ANR (was active)=yes on the dashboard.
💡 Motivation and Context
the thread that reports ANRs is
ANRWatchDog
, so right now it's gonna be alwayswas active=no
.as we have an
ExceptionMechanismException
that takes athread
, main thread in the case, we can fix this easily.to discuss: because of the change in this PR, the selected thread on the thread selector (dashboard) will be wrong, as the thread that reported the ANR is not the thread that has a stack trace.
💚 How did you test it?
tests already exist.
📝 Checklist
🔮 Next steps