Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

fix: add Abnormal to the Session.State enum as its part of the protocol #424

Merged
merged 2 commits into from
May 19, 2020
Merged

fix: add Abnormal to the Session.State enum as its part of the protocol #424

merged 2 commits into from
May 19, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented May 19, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

fix: add Abnormal to the Session.State enum as its part of the protocol

💡 Motivation and Context

this would make the current version be compatible with older generated sessions data.
but it's not currently being used by the SDK.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@marandaneto marandaneto requested a review from bruno-garcia as a code owner May 19, 2020 15:50
@marandaneto marandaneto changed the title add Abnormal to the State enum as its part of the protocol fix: add Abnormal to the Session.State enum as its part of the protocol May 19, 2020
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@fb3680e). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #424   +/-   ##
=========================================
  Coverage          ?   60.19%           
  Complexity        ?      809           
=========================================
  Files             ?       92           
  Lines             ?     3748           
  Branches          ?      360           
=========================================
  Hits              ?     2256           
  Misses            ?     1338           
  Partials          ?      154           
Impacted Files Coverage Δ Complexity Δ
...try-core/src/main/java/io/sentry/core/Session.java 98.64% <100.00%> (ø) 27.00 <0.00> (?)
...o/sentry/core/SendFireAndForgetEnvelopeSender.java 78.26% <0.00%> (ø) 3.00% <0.00%> (?%)
.../java/io/sentry/core/protocol/OperatingSystem.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...ry/core/exception/ExceptionMechanismException.java 100.00% <0.00%> (ø) 4.00% <0.00%> (?%)
...c/main/java/io/sentry/core/DirectoryProcessor.java 68.62% <0.00%> (ø) 7.00% <0.00%> (?%)
...src/main/java/io/sentry/core/protocol/Message.java 33.33% <0.00%> (ø) 3.00% <0.00%> (?%)
...c/main/java/io/sentry/core/cache/SessionCache.java 53.63% <0.00%> (ø) 23.00% <0.00%> (?%)
...c/main/java/io/sentry/core/SentryEnvelopeItem.java 80.48% <0.00%> (ø) 10.00% <0.00%> (?%)
...java/io/sentry/core/transport/AsyncConnection.java 70.91% <0.00%> (ø) 19.00% <0.00%> (?%)
...main/java/io/sentry/core/util/CollectionUtils.java 14.28% <0.00%> (ø) 1.00% <0.00%> (?%)
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb3680e...c183ebd. Read the comment docs.

@marandaneto marandaneto merged commit 0363118 into getsentry:master May 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants