This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
fix: Sentry.init register integrations after creating main Hub instead of in the main Hub ctor #427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
fix: Sentry.init register integrations after creating main Hub instead of in the main Hub ctor
💡 Motivation and Context
when integrations are registered on Hub ctor and async integrations are fired,
it might and actually happened that integrations called captureSomething
and the Hub was still NoOp.
Registering integrations Sentry.init(...) makes sure that the Hub is already created.
💚 How did you test it?
📝 Checklist
🔮 Next steps
Find a proper way of registering global and only once integrations.