Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries for upload-proguard command for 507 status #2140

Closed
szokeasaurusrex opened this issue Sep 4, 2024 · 0 comments · Fixed by #2141
Closed

Add retries for upload-proguard command for 507 status #2140

szokeasaurusrex opened this issue Sep 4, 2024 · 0 comments · Fixed by #2141
Assignees

Comments

@szokeasaurusrex
Copy link
Member

szokeasaurusrex commented Sep 4, 2024

The upload_dif_archive function sometimes results in intermittent 507 failures, and we should retry these. Currently, in the upload-proguard command, we do not have any retries, so let's add these.

sentry-cli/src/api/mod.rs

Lines 1404 to 1417 in 8b89630

pub fn upload_dif_archive(&self, project: &str, file: &Path) -> ApiResult<Vec<DebugInfoFile>> {
let path = format!(
"/projects/{}/{}/files/dsyms/",
PathArg(self.org),
PathArg(project)
);
let mut form = curl::easy::Form::new();
form.part("file").file(file).add()?;
self.request(Method::Post, &path)?
.with_form_data(form)?
.progress_bar_mode(ProgressBarMode::Request)?
.send()?
.convert()
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant