Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command
sentry-cli debug-files bundle-jvm
for bundling Java (and other JVM based languages) sources #1551Add command
sentry-cli debug-files bundle-jvm
for bundling Java (and other JVM based languages) sources #1551Changes from 17 commits
ccb8b39
77c49a1
05f0c7e
1c8034c
6af257e
2adb20d
7fff72d
9fc5b01
f1a1a0e
80462d8
696c658
a883b56
7fea001
280c47f
4241cc4
3644f88
6084679
907dea9
958c8f4
c749169
76d8a16
73f0436
629ebdb
06e615b
f5a2ef3
ba0227a
624a52c
db04bee
c348d99
e05eacb
b83271d
04418d6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loewenheim something that we should refactor soon (whole
UploadContext
should have a constructor or aDefault
implementation, or a builder.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the whole
jvmbased
naming. We dont usePdbBased
,ElfBased
,ProguardBasd
etc. Might useJvmBundle
or justJvm
instead? wdyt @SwatinemThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I guess there's little risk in people actually thinking they need to upload a JVM. Can rename it here and in other PRs as this was suggested before. Happy to rename and make it easier to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, naming is only one of the hardest things in software… :-D I’m okay with the naming. It clearly states that we have are dealing with any of the myriad of languages that compile to java bytecode and run on the jvm.