Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(python): Stop building Python package #1972

Closed
wants to merge 1 commit into from
Closed

build(python): Stop building Python package #1972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 0 additions & 43 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,49 +167,6 @@ jobs:
name: ${{ github.sha }}
path: '*.tgz'

python-base:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sentry and getsentry are using this -- could you please restore the python package?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile-sentry Craft fails whenever we attempt to release the Python package (see #1938). I think we tried upgrading the Debian version we use in Craft to fix this, but that broke something else (JS releases, I think).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unaware though that we use the Python package in sentry and getsentry – we should probably prioritize looking into coming up with a fix in Craft then so we can start making Python releases

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @vaind found the cause of the node20 upgrade breaking things -- but looks like they didn't push through with fixing it getsentry/craft#518

Copy link
Member Author

@szokeasaurusrex szokeasaurusrex Mar 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile-sentry Making sure I understood correctly: based on your comment, it sounds like we know the cause of the problem but it is not fixed yet, correct? I am confused because the issue you linked is closed.

Should I open a new issue in Craft about Sentry CLI Python releases being broken, or should we just reopen the getsentry/craft#518 and perhaps add a comment to mention that the issue is blocking Python releases?

name: python (base)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions-rs/toolchain@16499b5e05bf2e26879000db0c1d13f7e13fa3af # pin@v1
with:
toolchain: stable
target: x86_64-unknown-linux-musl
profile: minimal
override: true
- uses: actions/setup-python@v4
with:
python-version: '3.11'
- run: python3 -m pip install build && python3 -m build
- uses: actions/upload-artifact@v3.1.1
with:
name: ${{ github.sha }}-python-base
path: dist/*

python:
name: python
runs-on: ubuntu-latest
needs: [linux, macos, macos_universal, windows, python-base]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: '3.11'
- uses: actions/download-artifact@v3
with:
name: ${{ github.sha }}
path: binaries
- uses: actions/download-artifact@v3
with:
name: ${{ github.sha }}-python-base
path: python-base
- run: scripts/wheels --binaries binaries --base python-base --dest dist
- uses: actions/upload-artifact@v3.1.1
with:
name: ${{ github.sha }}
path: dist/*

npm-distributions:
name: 'Build NPM distributions'
runs-on: ubuntu-latest
Expand Down
2 changes: 0 additions & 2 deletions pyproject.toml
View file
Open in desktop

This file was deleted.

174 changes: 0 additions & 174 deletions scripts/wheels
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions setup.cfg
View file
Open in desktop

This file was deleted.

26 changes: 0 additions & 26 deletions setup.py
View file
Open in desktop

This file was deleted.

Loading