feat(commands): add send-metric command #2045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CLI command that can emit metrics. Fixes GH-2001
added 5 commits
April 30, 2024 11:27
src/utils/metrics/tags.rs
Outdated
| use regex::Regex; | ||
| use std::collections::HashMap; | ||
|
|
||
| pub(super) struct NormalizedTags { |
There was a problem hiding this comment.
I think I would just call this struct something like MetricsTags, then have a function defined on the struct which normalizes all the tags
There was a problem hiding this comment.
Please look at it again after offline discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CLI command that can emit metrics.
Fixes GH-2001