Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: Delete stale.yml workflow #2076

Merged
merged 1 commit into from
May 31, 2024

Conversation

szokeasaurusrex
Copy link
Member

We have deleted this workflow in other repos (e.g. getsentry/sentry-python#2245), and we should probably delete it here as well, by the same logic.

We have deleted this workflow in other repos (e.g. getsentry/sentry-python#2245), and we should probably delete it here as well, by the same logic.
@szokeasaurusrex
Copy link
Member Author

szokeasaurusrex commented May 31, 2024

Before merging this PR, we need to make sure that the new stalebot logic also applies to the sentry-cli repo. I found that the list of repos is defined here as a concatenation of SENTRY_MONOREPOS and SENTRY_SDK_REPOS, but since I was unable to find where these constants are defined, I am unsure whether sentry-cli is included. If it is not included, maybe it should be.

@chadwhitacre or @hubertdeng123, can one of you confirm whether sentry-cli is being monitored by the new stalebot logic?

@hubertdeng123
Copy link
Member

Yep, sentry-cli is being monitored by stalebot in eng-pipes: https://github.com/getsentry/eng-pipes/blob/950e5365bba331bee1cbdf063ac2ef78ecd11856/github-orgs.yml#L55

This should be safe to do

@szokeasaurusrex szokeasaurusrex merged commit 9e0ae85 into master May 31, 2024
12 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/delete-stale-yml branch May 31, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants