Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Measure slow and frozen frames #1123

Merged
merged 102 commits into from
Jun 11, 2021
Merged

feat: Measure slow and frozen frames #1123

merged 102 commits into from
Jun 11, 2021

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented May 20, 2021

📜 Description

Measure slow, frozen, and total frames and attach these as measurements to every transaction for iOS, tvOS, and Mac Catalyst.

💡 Motivation and Context

We want to give our users insights on how many slow, frozen and total frames a transaction has.

💚 How did you test it?

Unit tests, Simulator, and real devices.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

Create docs for this.

@philipphofmann philipphofmann requested a review from a team May 20, 2021 12:52
@github-actions
Copy link

github-actions bot commented May 20, 2021

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 5128a7a

Base automatically changed from feat/app-start-measurement to master June 8, 2021 08:19
@philipphofmann philipphofmann requested a review from a team June 8, 2021 14:49
@marandaneto
Copy link
Contributor

left a few minor comments but overall looks good, thanks!

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipphofmann philipphofmann enabled auto-merge (squash) June 11, 2021 13:37
@philipphofmann philipphofmann merged commit 7c20e71 into master Jun 11, 2021
@philipphofmann philipphofmann deleted the feat/fps branch June 11, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants