-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Measure slow and frozen frames #1123
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Measure app start time for cold and warm starts and send it as a measurement along with the first transaction after the app start.
|
marandaneto
reviewed
Jun 11, 2021
marandaneto
reviewed
Jun 11, 2021
marandaneto
reviewed
Jun 11, 2021
marandaneto
reviewed
Jun 11, 2021
marandaneto
reviewed
Jun 11, 2021
marandaneto
reviewed
Jun 11, 2021
Tests/SentryTests/Integrations/SentryFramesTrackingIntegrationTests.swift
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Jun 11, 2021
marandaneto
reviewed
Jun 11, 2021
left a few minor comments but overall looks good, thanks! |
marandaneto
approved these changes
Jun 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Measure slow, frozen, and total frames and attach these as measurements to every transaction for iOS, tvOS, and Mac Catalyst.
💡 Motivation and Context
We want to give our users insights on how many slow, frozen and total frames a transaction has.
💚 How did you test it?
Unit tests, Simulator, and real devices.
📝 Checklist
🔮 Next steps
Create docs for this.