-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add missing atomic import #2683
Conversation
Add missing atomic import for SentryProfilingConditionals as for some nightly Swift versions the project didn't compile. Fixes GH-2678
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ecd9ecd | 1241.28 ms | 1260.35 ms | 19.07 ms |
bd2afa6 | 1241.37 ms | 1246.20 ms | 4.83 ms |
4c00f8c | 1231.62 ms | 1237.76 ms | 6.14 ms |
ecd9ecd | 1215.77 ms | 1238.70 ms | 22.93 ms |
443723a | 1205.24 ms | 1220.52 ms | 15.28 ms |
83d2d84 | 1211.31 ms | 1227.34 ms | 16.03 ms |
b6ba04e | 1230.48 ms | 1253.20 ms | 22.72 ms |
bd2afa6 | 1245.24 ms | 1263.18 ms | 17.94 ms |
4977fbc | 1217.26 ms | 1239.82 ms | 22.56 ms |
7c5d161 | 1224.38 ms | 1249.66 ms | 25.28 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ecd9ecd | 20.76 KiB | 420.23 KiB | 399.47 KiB |
bd2afa6 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
4c00f8c | 20.76 KiB | 419.62 KiB | 398.86 KiB |
ecd9ecd | 20.76 KiB | 420.23 KiB | 399.47 KiB |
443723a | 20.76 KiB | 414.44 KiB | 393.68 KiB |
83d2d84 | 20.76 KiB | 419.66 KiB | 398.90 KiB |
b6ba04e | 20.76 KiB | 414.44 KiB | 393.68 KiB |
bd2afa6 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
4977fbc | 20.76 KiB | 419.85 KiB | 399.10 KiB |
7c5d161 | 20.76 KiB | 414.44 KiB | 393.68 KiB |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2683 +/- ##
==========================================
+ Coverage 80.52% 80.69% +0.17%
==========================================
Files 247 247
Lines 22862 22872 +10
Branches 10121 10128 +7
==========================================
+ Hits 18409 18457 +48
+ Misses 3990 3958 -32
+ Partials 463 457 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix 🚢
📜 Description
Add missing atomic import for SentryProfilingConditionals as for some nightly Swift versions the project didn't compile.
💡 Motivation and Context
Fixes GH-2678
💚 How did you test it?
I didn't. Testing this with a nightly swift version is not worth the effort. We only added one import.
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps