Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing atomic import #2683

Merged
merged 2 commits into from
Feb 8, 2023
Merged

fix: Add missing atomic import #2683

merged 2 commits into from
Feb 8, 2023

Conversation

philipphofmann
Copy link
Member

📜 Description

Add missing atomic import for SentryProfilingConditionals as for some nightly Swift versions the project didn't compile.

💡 Motivation and Context

Fixes GH-2678

💚 How did you test it?

I didn't. Testing this with a nightly swift version is not worth the effort. We only added one import.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Add missing atomic import for SentryProfilingConditionals as for some
nightly Swift versions the project didn't compile.

Fixes GH-2678
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1213.72 ms 1245.16 ms 31.44 ms
Size 20.76 KiB 420.55 KiB 399.79 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ecd9ecd 1241.28 ms 1260.35 ms 19.07 ms
bd2afa6 1241.37 ms 1246.20 ms 4.83 ms
4c00f8c 1231.62 ms 1237.76 ms 6.14 ms
ecd9ecd 1215.77 ms 1238.70 ms 22.93 ms
443723a 1205.24 ms 1220.52 ms 15.28 ms
83d2d84 1211.31 ms 1227.34 ms 16.03 ms
b6ba04e 1230.48 ms 1253.20 ms 22.72 ms
bd2afa6 1245.24 ms 1263.18 ms 17.94 ms
4977fbc 1217.26 ms 1239.82 ms 22.56 ms
7c5d161 1224.38 ms 1249.66 ms 25.28 ms

App size

Revision Plain With Sentry Diff
ecd9ecd 20.76 KiB 420.23 KiB 399.47 KiB
bd2afa6 20.76 KiB 420.55 KiB 399.79 KiB
4c00f8c 20.76 KiB 419.62 KiB 398.86 KiB
ecd9ecd 20.76 KiB 420.23 KiB 399.47 KiB
443723a 20.76 KiB 414.44 KiB 393.68 KiB
83d2d84 20.76 KiB 419.66 KiB 398.90 KiB
b6ba04e 20.76 KiB 414.44 KiB 393.68 KiB
bd2afa6 20.76 KiB 420.55 KiB 399.79 KiB
4977fbc 20.76 KiB 419.85 KiB 399.10 KiB
7c5d161 20.76 KiB 414.44 KiB 393.68 KiB

Previous results on branch: fix/import-atomic

Startup times

Revision Plain With Sentry Diff
8a977d1 1198.60 ms 1226.94 ms 28.34 ms

App size

Revision Plain With Sentry Diff
8a977d1 20.76 KiB 420.55 KiB 399.79 KiB

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #2683 (636f6b2) into main (bd2afa6) will increase coverage by 0.17%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2683      +/-   ##
==========================================
+ Coverage   80.52%   80.69%   +0.17%     
==========================================
  Files         247      247              
  Lines       22862    22872      +10     
  Branches    10121    10128       +7     
==========================================
+ Hits        18409    18457      +48     
+ Misses       3990     3958      -32     
+ Partials      463      457       -6     
Impacted Files Coverage Δ
Sources/Sentry/SentryRequestOperation.m 67.56% <0.00%> (-10.82%) ⬇️
Sources/Sentry/SentryFileManager.m 95.06% <0.00%> (ø)
Sources/Sentry/SentryCrashIntegration.m 98.66% <0.00%> (+0.03%) ⬆️
Sources/Sentry/SentryNetworkTracker.m 95.30% <0.00%> (+0.09%) ⬆️
Sources/Sentry/SentryMachLogging.cpp 3.51% <0.00%> (+1.00%) ⬆️
Sources/Sentry/SentryBacktrace.cpp 90.17% <0.00%> (+1.78%) ⬆️
Sources/Sentry/SentryThreadInspector.m 98.00% <0.00%> (+2.00%) ⬆️
Sources/Sentry/SentryThreadHandle.cpp 72.67% <0.00%> (+3.27%) ⬆️
Sources/Sentry/SentryThreadMetadataCache.cpp 95.65% <0.00%> (+4.34%) ⬆️
Sources/SentryCrash/Recording/Tools/fishhook.c 82.27% <0.00%> (+5.06%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd2afa6...636f6b2. Read the comment docs.

Copy link
Member

@armcknight armcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix 🚢

@philipphofmann philipphofmann merged commit 8f397a7 into main Feb 8, 2023
@philipphofmann philipphofmann deleted the fix/import-atomic branch February 8, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Include in SamplingProfiler
2 participants