Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: use xcode-test.sh to run sanitizers #3318

Closed
wants to merge 19 commits into from
Closed

ref: use xcode-test.sh to run sanitizers #3318

wants to merge 19 commits into from

Conversation

armcknight
Copy link
Member

#skip-changelog

@armcknight armcknight marked this pull request as draft September 29, 2023 23:23
philipphofmann
philipphofmann reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I like the idea of removing the extra script. Once it works, LGTM.

@armcknight armcknight force-pushed the armcknight/ci/3200-fix-thread-sanitizer branch from 372aa8d to d99c31e Compare October 20, 2023 23:48
@armcknight
Copy link
Member Author

armcknight commented Oct 27, 2023 •
edited
Loading

Going to close this for now, because if the method of running tests diverges too much given our plan from #3303, this will just become a nasty leaky abstraction.

@armcknight armcknight closed this Oct 27, 2023
@armcknight armcknight deleted the armcknight/refactor-running-tsan-tests branch February 16, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipphofmann philipphofmann philipphofmann left review comments

@brustolin brustolin Awaiting requested review from brustolin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armcknight @philipphofmann