Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix: App hang being reported from background" #3370

Closed

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Nov 2, 2023

Revert #3298 because ProfilingUITests.testProfilingGPUInfo continuously fails after merging #3298 to the main branch.

I could reproduce ProfilingUITests.testProfilingGPUInfo failing when running all UITests locally. Only running ProfilingUITests.testProfilingGPUInfo succeeds. Commenting out the following code made the test work again.

#if SENTRY_HAS_UIKIT
// If the app is not active, the main thread may be blocked or too busy.
// Since there is no UI for the user to interact, there is no need to report app hang.
if (SentryDependencyContainer.sharedInstance.application.applicationState
!= UIApplicationStateActive) {
return;
}
#endif

#skip-changelog

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #3370 (7225fc9) into main (dd0557f) will increase coverage by 0.075%.
The diff coverage is 100.000%.

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3370       +/-   ##
=============================================
+ Coverage   89.181%   89.257%   +0.075%     
=============================================
  Files          500       500               
  Lines        54683     54669       -14     
  Branches     19620     19621        +1     
=============================================
+ Hits         48767     48796       +29     
- Misses        4928      5004       +76     
+ Partials       988       869      -119     
Files Coverage Δ
Sources/Sentry/SentryANRTrackingIntegration.m 95.348% <ø> (-0.570%) ⬇️
Sources/Sentry/SentryUIApplication.m 88.571% <ø> (-0.903%) ⬇️
...ations/ANR/SentryANRTrackingIntegrationTests.swift 92.198% <100.000%> (-0.705%) ⬇️

... and 38 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd0557f...7225fc9. Read the comment docs.

Copy link

github-actions bot commented Nov 2, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1261.92 ms 1265.98 ms 4.06 ms
Size 22.85 KiB 411.57 KiB 388.72 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a176fc4 1226.24 ms 1247.50 ms 21.26 ms
51307b7 1223.08 ms 1240.76 ms 17.68 ms
8f212af 1246.41 ms 1270.98 ms 24.57 ms
621ba9b 1190.66 ms 1230.84 ms 40.18 ms
56ec5d0 1236.65 ms 1261.90 ms 25.25 ms
c6773e5 1222.48 ms 1240.02 ms 17.54 ms
98cca71 1230.43 ms 1252.36 ms 21.93 ms
5b6694b 1221.71 ms 1259.06 ms 37.35 ms
69d8759 1229.88 ms 1240.45 ms 10.57 ms
d253cdf 1231.61 ms 1259.52 ms 27.91 ms

App size

Revision Plain With Sentry Diff
a176fc4 22.84 KiB 403.24 KiB 380.39 KiB
51307b7 22.85 KiB 407.63 KiB 384.78 KiB
8f212af 22.84 KiB 403.14 KiB 380.29 KiB
621ba9b 20.76 KiB 414.45 KiB 393.69 KiB
56ec5d0 20.76 KiB 414.44 KiB 393.69 KiB
c6773e5 20.76 KiB 435.25 KiB 414.49 KiB
98cca71 22.85 KiB 411.14 KiB 388.29 KiB
5b6694b 20.76 KiB 426.11 KiB 405.34 KiB
69d8759 20.76 KiB 393.05 KiB 372.29 KiB
d253cdf 20.76 KiB 427.66 KiB 406.90 KiB

@philipphofmann
Copy link
Member Author

Will be fixed with #3372.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant