-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add frames delay to transactions #3487
Conversation
Add total, slow and frozen frame numbers to span data. Fixes GH-3448
Co-authored-by: Andrew McKnight <andrew.mcknight@sentry.io>
Co-authored-by: Andrew McKnight <andrew.mcknight@sentry.io>
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ddc9b9a | 1201.71 ms | 1226.70 ms | 24.99 ms |
a6f8b18 | 1238.54 ms | 1265.56 ms | 27.02 ms |
bd2cb64 | 1216.14 ms | 1241.78 ms | 25.64 ms |
3a31fc9 | 1237.35 ms | 1249.02 ms | 11.67 ms |
4b08ceb | 1237.75 ms | 1249.61 ms | 11.86 ms |
881a955 | 1222.16 ms | 1237.22 ms | 15.06 ms |
3437454 | 1235.54 ms | 1244.82 ms | 9.28 ms |
6c31077 | 1233.80 ms | 1245.34 ms | 11.54 ms |
2af280d | 1227.86 ms | 1240.36 ms | 12.50 ms |
9d56232 | 1192.09 ms | 1228.86 ms | 36.77 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ddc9b9a | 20.76 KiB | 420.40 KiB | 399.65 KiB |
a6f8b18 | 20.76 KiB | 431.87 KiB | 411.11 KiB |
bd2cb64 | 22.85 KiB | 413.45 KiB | 390.60 KiB |
3a31fc9 | 20.76 KiB | 414.45 KiB | 393.69 KiB |
4b08ceb | 20.76 KiB | 431.99 KiB | 411.23 KiB |
881a955 | 22.85 KiB | 407.63 KiB | 384.78 KiB |
3437454 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
6c31077 | 22.84 KiB | 401.65 KiB | 378.81 KiB |
2af280d | 20.76 KiB | 435.22 KiB | 414.46 KiB |
9d56232 | 20.76 KiB | 425.80 KiB | 405.04 KiB |
Previous results on branch: feat/frame-delay
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7971d04 | 1203.70 ms | 1232.47 ms | 28.77 ms |
d7c8764 | 1216.94 ms | 1229.13 ms | 12.19 ms |
acfb07d | 1220.59 ms | 1231.10 ms | 10.51 ms |
be5eebc | 1232.80 ms | 1240.37 ms | 7.57 ms |
187485e | 1245.55 ms | 1261.12 ms | 15.57 ms |
261201d | 1238.31 ms | 1252.24 ms | 13.93 ms |
806f634 | 1202.00 ms | 1212.79 ms | 10.79 ms |
773497b | 1195.69 ms | 1217.18 ms | 21.49 ms |
8866a9f | 1244.98 ms | 1264.70 ms | 19.72 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7971d04 | 21.58 KiB | 417.78 KiB | 396.19 KiB |
d7c8764 | 21.58 KiB | 418.06 KiB | 396.48 KiB |
acfb07d | 21.58 KiB | 418.11 KiB | 396.53 KiB |
be5eebc | 21.58 KiB | 418.06 KiB | 396.48 KiB |
187485e | 21.58 KiB | 417.99 KiB | 396.41 KiB |
261201d | 21.58 KiB | 418.11 KiB | 396.53 KiB |
806f634 | 21.58 KiB | 418.13 KiB | 396.54 KiB |
773497b | 21.58 KiB | 418.13 KiB | 396.55 KiB |
8866a9f | 21.58 KiB | 418.11 KiB | 396.53 KiB |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3487 +/- ##
=============================================
+ Coverage 89.056% 89.180% +0.123%
=============================================
Files 526 528 +2
Lines 56937 57403 +466
Branches 20476 20569 +93
=============================================
+ Hits 50706 51192 +486
+ Misses 5312 5294 -18
+ Partials 919 917 -2
... and 24 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just left a few small comments
📜 Description
Add frames delay measurement to transactions. I will open an extra PR to add the measurement as span data to spans because this PR is already huge.
💡 Motivation and Context
Fixes GH-3481
💚 How did you test it?
Unit tests, simulator and a real device.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps