Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add native SDK information in the replay option event #4663

Merged
merged 21 commits into from
Jan 16, 2025

Conversation

brustolin
Copy link
Contributor

@brustolin brustolin commented Dec 23, 2024

📜 Description

Added cocoa name and version in the session replay options event for easy investigation.

image

💚 How did you test it?

Unit test

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

github-actions bot commented Dec 23, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against cc95c89

CHANGELOG.md Outdated Show resolved Hide resolved
@brustolin brustolin mentioned this pull request Dec 23, 2024
7 tasks
Copy link

github-actions bot commented Dec 23, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1240.49 ms 1251.41 ms 10.92 ms
Size 22.31 KiB 768.90 KiB 746.59 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3bf3c92 1236.94 ms 1253.00 ms 16.06 ms
9ae806a 1243.84 ms 1256.22 ms 12.39 ms
b4f8dba 1343.92 ms 1362.96 ms 19.04 ms
dc8ab43 1220.39 ms 1238.04 ms 17.65 ms
8919322 1262.67 ms 1269.90 ms 7.22 ms
7419285 1209.53 ms 1244.72 ms 35.19 ms
e70a2e1 1224.44 ms 1239.12 ms 14.68 ms
3f366ee 1242.28 ms 1260.80 ms 18.52 ms
3db3e35 1248.02 ms 1258.35 ms 10.33 ms
973d574 1236.20 ms 1253.79 ms 17.59 ms

App size

Revision Plain With Sentry Diff
3bf3c92 21.58 KiB 706.06 KiB 684.48 KiB
9ae806a 21.58 KiB 616.14 KiB 594.56 KiB
b4f8dba 21.58 KiB 614.87 KiB 593.29 KiB
dc8ab43 21.58 KiB 697.83 KiB 676.25 KiB
8919322 22.84 KiB 403.18 KiB 380.34 KiB
7419285 20.76 KiB 432.99 KiB 412.22 KiB
e70a2e1 21.58 KiB 655.73 KiB 634.15 KiB
3f366ee 20.76 KiB 427.84 KiB 407.08 KiB
3db3e35 21.58 KiB 419.21 KiB 397.63 KiB
973d574 21.58 KiB 542.39 KiB 520.80 KiB

Previous results on branch: feat/sdk-info-sr-tags

Startup times

Revision Plain With Sentry Diff
7cdca55 1240.24 ms 1256.24 ms 16.00 ms
b7ac501 1230.59 ms 1253.66 ms 23.07 ms
37adb91 1240.06 ms 1261.49 ms 21.43 ms
32a98c1 1227.61 ms 1252.87 ms 25.26 ms
369ece1 1233.46 ms 1257.61 ms 24.15 ms
8e3d9eb 1225.58 ms 1258.66 ms 33.08 ms
62c1f93 1236.84 ms 1256.41 ms 19.56 ms

App size

Revision Plain With Sentry Diff
7cdca55 22.32 KiB 761.54 KiB 739.22 KiB
b7ac501 22.32 KiB 761.95 KiB 739.63 KiB
37adb91 22.31 KiB 761.39 KiB 739.08 KiB
32a98c1 22.32 KiB 762.11 KiB 739.79 KiB
369ece1 22.31 KiB 769.03 KiB 746.71 KiB
8e3d9eb 22.31 KiB 768.84 KiB 746.52 KiB
62c1f93 22.31 KiB 761.40 KiB 739.08 KiB

@brustolin brustolin marked this pull request as draft December 23, 2024 16:23
@brustolin brustolin marked this pull request as ready for review December 24, 2024 08:44
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.205%. Comparing base (9c173e4) to head (cc95c89).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4663       +/-   ##
=============================================
- Coverage   91.225%   91.205%   -0.021%     
=============================================
  Files          624       624               
  Lines        72083     72146       +63     
  Branches     26221     26256       +35     
=============================================
+ Hits         65758     65801       +43     
- Misses        6229      6247       +18     
- Partials        96        98        +2     
Files with missing lines Coverage Δ
Sources/Sentry/SentryClient.m 95.184% <100.000%> (+0.034%) ⬆️
.../SessionReplay/RRWeb/SentryRRWebOptionsEvent.swift 100.000% <100.000%> (ø)
...tegrations/SessionReplay/SentryReplayOptions.swift 95.000% <100.000%> (+0.084%) ⬆️
...tegrations/SessionReplay/SentrySessionReplay.swift 97.619% <100.000%> (+0.009%) ⬆️
...tions/SessionReplay/SentrySessionReplayTests.swift 99.111% <100.000%> (+0.041%) ⬆️
Tests/SentryTests/SentryClientTests.swift 98.054% <100.000%> (+0.019%) ⬆️

... and 18 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c173e4...cc95c89. Read the comment docs.

Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is PR highly confusing to me. The SentryMeta sdkName and SDKVersion can be changed, and only SR events would use the nativeVersionString and nativeSDKName. All other Sentry data uses the SentryMeta sdkName and sdkVersion. @romtsn, do you use a similar approach on Android? If yes, what are the reasons for that?

Sources/Sentry/SentryMeta.m Outdated Show resolved Hide resolved
@kahest kahest mentioned this pull request Jan 8, 2025
@brustolin
Copy link
Contributor Author

This is PR highly confusing to me

Replay needs the information of the native SDK on top of the hybrid SDK info.

@krystofwoldrich
Copy link
Member

Hello everyone,
getsentry/sentry-react-native#4450 RN is waiting for this PR, what is the conclusion of the discussion above?

Can this be merged and released?

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better thanks @brustolin and @romtsn for aligning, LGTM

@brustolin brustolin merged commit f3b8999 into main Jan 16, 2025
69 of 70 checks passed
@brustolin brustolin deleted the feat/sdk-info-sr-tags branch January 16, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants