Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sentryReplayUnmask and sentryReplayUnmask preventing interaction #4749

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

brustolin
Copy link
Contributor

📜 Description

Adding sentryReplayUnmask and sentryReplayUnmask to a view was preventing interaction with such view.
Solved now.

💚 How did you test it?

Sample and UITest

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

github-actions bot commented Jan 23, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.65 ms 1240.71 ms 12.06 ms
Size 22.31 KiB 775.14 KiB 752.83 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
279841c 1250.80 ms 1263.08 ms 12.29 ms
a176fc4 1239.78 ms 1258.98 ms 19.20 ms
d26797f 1226.98 ms 1240.14 ms 13.16 ms
e19cca3 1215.39 ms 1235.21 ms 19.83 ms
becc941 1221.90 ms 1240.37 ms 18.47 ms
279841c 1231.41 ms 1245.65 ms 14.24 ms
c319795 1220.06 ms 1248.50 ms 28.44 ms
94d8eb3 1234.02 ms 1249.63 ms 15.60 ms
d10ae0c 1250.02 ms 1253.74 ms 3.72 ms
bee3e88 1232.65 ms 1247.33 ms 14.68 ms

App size

Revision Plain With Sentry Diff
279841c 22.84 KiB 403.19 KiB 380.34 KiB
a176fc4 22.84 KiB 403.24 KiB 380.39 KiB
d26797f 21.58 KiB 682.39 KiB 660.81 KiB
e19cca3 21.58 KiB 669.74 KiB 648.16 KiB
becc941 21.58 KiB 419.82 KiB 398.24 KiB
279841c 22.84 KiB 403.19 KiB 380.35 KiB
c319795 20.76 KiB 431.99 KiB 411.22 KiB
94d8eb3 21.58 KiB 417.86 KiB 396.28 KiB
d10ae0c 20.76 KiB 419.86 KiB 399.10 KiB
bee3e88 22.30 KiB 749.95 KiB 727.64 KiB

Previous results on branch: fix/SwiftUI-SR-Masking-touch

Startup times

Revision Plain With Sentry Diff
a937b8f 1223.14 ms 1242.18 ms 19.04 ms

App size

Revision Plain With Sentry Diff
a937b8f 22.31 KiB 775.15 KiB 752.83 KiB

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.193%. Comparing base (f5a9f3f) to head (385f1ae).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4749       +/-   ##
=============================================
+ Coverage   91.112%   91.193%   +0.080%     
=============================================
  Files          623       623               
  Lines        72495     72500        +5     
  Branches     25785     26416      +631     
=============================================
+ Hits         66052     66115       +63     
+ Misses        6351      6286       -65     
- Partials        92        99        +7     

see 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a9f3f...385f1ae. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
@brustolin brustolin merged commit ba3679b into main Jan 24, 2025
71 checks passed
@brustolin brustolin deleted the fix/SwiftUI-SR-Masking-touch branch January 24, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants