chore(ci): refactor xcode-test from positional to named arguments #4808
+143
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
scripts/xcode-test.sh
to use named arguments instead of positional.This should improve usability of the script, and reduce accidental usage errors when changing the script.
Furthermore it surfaced that the 7th argument
${{ matrix.scheme }}
is actually used as theDERIVED_DATA
path, instead of the 8th argumentsentry-cocoa/.github/workflows/test.yml
Line 188 in bdd896e
sentry-cocoa/scripts/xcode-test.sh
Lines 11 to 18 in bdd896e
#skip-changelog