Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Measure app hang duration #4829

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

philipphofmann
Copy link
Member

Measure the app hang duration for ANRTrackerV2 and report it via the delegate.anrStopped, so we can set the app hang duration in the ANRTrackingIntegration in a future PR.

Required for #2216.

#skip-changelog

Measure the app hang duration for ANRTrackerV2 and report it via
the delegate.anrStopped, so we can set the app hang duration in the
ANRTrackingIntegration in a future PR.
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 97.65625% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.468%. Comparing base (44332bf) to head (4bfa7f3).

Files with missing lines Patch % Lines
...sts/Integrations/ANR/SentryANRTrackerV2Tests.swift 98.019% 2 Missing ⚠️
...sts/Integrations/ANR/SentryANRTrackerV1Tests.swift 80.000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4829       +/-   ##
=============================================
- Coverage   91.535%   91.468%   -0.068%     
=============================================
  Files          656       657        +1     
  Lines        76636     76748      +112     
  Branches     27708     27000      -708     
=============================================
+ Hits         70149     70200       +51     
- Misses        6389      6455       +66     
+ Partials        98        93        -5     
Files with missing lines Coverage Δ
Sources/Sentry/SentryANRTrackerV1.m 99.180% <100.000%> (ø)
Sources/Sentry/SentryANRTrackerV2.m 98.843% <100.000%> (+0.109%) ⬆️
Sources/Sentry/SentryANRTrackingIntegration.m 97.058% <ø> (ø)
...try/SentryWatchdogTerminationTrackingIntegration.m 84.375% <ø> (-6.250%) ⬇️
.../Integrations/ANR/SentryANRTrackerV2Delegate.swift 100.000% <100.000%> (ø)
...sts/Integrations/ANR/SentryANRTrackerV1Tests.swift 98.514% <80.000%> (+0.022%) ⬆️
...sts/Integrations/ANR/SentryANRTrackerV2Tests.swift 99.613% <98.019%> (-0.387%) ⬇️

... and 28 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44332bf...4bfa7f3. Read the comment docs.

Copy link

github-actions bot commented Feb 11, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.76 ms 1220.98 ms 1.22 ms
Size 22.31 KiB 818.08 KiB 795.76 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
65f104b 1229.87 ms 1247.69 ms 17.82 ms
46f5eb8 1212.27 ms 1231.42 ms 19.15 ms
0f30019 1239.22 ms 1240.04 ms 0.82 ms
c0ff306 1218.92 ms 1240.64 ms 21.72 ms
c021422 1237.12 ms 1263.18 ms 26.06 ms
bb5dc7d 1240.44 ms 1266.45 ms 26.01 ms
160a073 1260.72 ms 1270.10 ms 9.38 ms
9ae806a 1243.84 ms 1256.22 ms 12.39 ms
188547e 1241.47 ms 1257.35 ms 15.88 ms
156e771 1228.06 ms 1242.64 ms 14.58 ms

App size

Revision Plain With Sentry Diff
65f104b 21.58 KiB 625.82 KiB 604.24 KiB
46f5eb8 20.76 KiB 432.37 KiB 411.61 KiB
0f30019 22.84 KiB 405.39 KiB 382.54 KiB
c0ff306 20.76 KiB 434.65 KiB 413.89 KiB
c021422 20.76 KiB 435.64 KiB 414.88 KiB
bb5dc7d 22.85 KiB 412.98 KiB 390.13 KiB
160a073 22.85 KiB 408.88 KiB 386.03 KiB
9ae806a 21.58 KiB 616.14 KiB 594.56 KiB
188547e 21.58 KiB 424.34 KiB 402.76 KiB
156e771 20.76 KiB 419.70 KiB 398.94 KiB

Previous results on branch: feat/measure-app-hang-duration

Startup times

Revision Plain With Sentry Diff
3350356 1206.78 ms 1247.06 ms 40.28 ms

App size

Revision Plain With Sentry Diff
3350356 22.31 KiB 817.70 KiB 795.39 KiB

@philipphofmann philipphofmann marked this pull request as draft February 11, 2025 14:56
@philipphofmann
Copy link
Member Author

philipphofmann commented Feb 11, 2025

Converted this back to a draft to change the errorMessage to min and max duration for the delegate.

@philipphofmann philipphofmann marked this pull request as ready for review February 11, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant