VendorId should be a String (#1112)

getsentry · Nov 16, 2022 · 453e1bc · 453e1bc
1 parent 379d7a8
commit 453e1bc
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 ### Fixes
 
+- VendorId should be a String ([#1112](https://github.com/getsentry/sentry-dart/pull/1112))
 - Disable `enableUserInteractionBreadcrumbs` on Android when `enableAutoNativeBreadcrumbs` is disabled ([#1131](https://github.com/getsentry/sentry-dart/pull/1131))
 - Transaction name is reset after the transaction finishes ([#1125](https://github.com/getsentry/sentry-dart/pull/1125))
 
@@ -12,6 +13,9 @@
 - Bump Cocoa SDK from v7.30.2 to v7.31.0 ([#1132](https://github.com/getsentry/sentry-dart/pull/1132))
   - [changelog](https://github.com/getsentry/sentry-cocoa/blob/master/CHANGELOG.md#7310)
   - [diff](https://github.com/getsentry/sentry-cocoa/compare/7.30.2...7.31.0)
+- Bump Android SDK from v6.7.0 to v6.7.1 ([#1112](https://github.com/getsentry/sentry-dart/pull/1112))
+  - [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#671)
+  - [diff](https://github.com/getsentry/sentry-java/compare/6.7.0...6.7.1)
 
 ## 6.15.1
 

diff --git a/dart/lib/src/protocol/sentry_gpu.dart b/dart/lib/src/protocol/sentry_gpu.dart
@@ -24,7 +24,7 @@ class SentryGpu {
   final int? id;
 
   /// The PCI vendor identifier of the graphics device.
-  final int? vendorId;
+  final String? vendorId;
 
   /// The vendor name as reported by the graphics device.
   final String? vendorName;
@@ -150,7 +150,7 @@ class SentryGpu {
   SentryGpu copyWith({
     String? name,
     int? id,
-    int? vendorId,
+    String? vendorId,
     String? vendorName,
     int? memorySize,
     String? apiType,

diff --git a/dart/test/protocol/sentry_gpu_test.dart b/dart/test/protocol/sentry_gpu_test.dart
@@ -6,7 +6,7 @@ void main() {
   final sentryGpu = SentryGpu(
       name: 'fixture-name',
       id: 1,
-      vendorId: 2,
+      vendorId: '2',
       vendorName: 'fixture-vendorName',
       memorySize: 3,
       apiType: 'fixture-apiType',
@@ -17,7 +17,7 @@ void main() {
   final sentryGpuJson = <String, dynamic>{
     'name': 'fixture-name',
     'id': 1,
-    'vendor_id': 2,
+    'vendor_id': '2',
     'vendor_name': 'fixture-vendorName',
     'memory_size': 3,
     'api_type': 'fixture-apiType',
@@ -63,7 +63,7 @@ void main() {
       final copy = data.copyWith(
         name: 'name1',
         id: 11,
-        vendorId: 22,
+        vendorId: '22',
         vendorName: 'vendorName1',
         memorySize: 33,
         apiType: 'apiType1',
@@ -74,7 +74,7 @@ void main() {
 
       expect('name1', copy.name);
       expect(11, copy.id);
-      expect(22, copy.vendorId);
+      expect('22', copy.vendorId);
       expect('vendorName1', copy.vendorName);
       expect(33, copy.memorySize);
       expect('apiType1', copy.apiType);

diff --git a/flutter/android/build.gradle b/flutter/android/build.gradle
@@ -54,6 +54,6 @@ android {
 }
 
 dependencies {
-    api 'io.sentry:sentry-android:6.7.0'
+    api 'io.sentry:sentry-android:6.7.1'
     implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
 }