Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for Android device ID generation #449

Closed
ueman opened this issue May 3, 2021 · 9 comments
Closed

Add option for Android device ID generation #449

ueman opened this issue May 3, 2021 · 9 comments

Comments

@ueman
Copy link
Collaborator

ueman commented May 3, 2021

See getsentry/sentry-java#1455 (comment)

@ueman
Copy link
Collaborator Author

ueman commented May 4, 2021

@marandaneto
Copy link
Contributor

yep, we could just tell people to define a beforeSendCallback and mutate the event.contexts.user.id and event.contexts.device.id, let's just run this ourselves and guarantees that it works, if it does, we add to our breaking changes docs

@bruno-garcia
Copy link
Member

It's a good thing to note on the migration page and release notes on GH.

@marandaneto
Copy link
Contributor

Android beta-2 is published, so this issue can be worked on

@ueman ueman self-assigned this May 10, 2021
@ueman
Copy link
Collaborator Author

ueman commented May 10, 2021

beforeSend wouldn't work because it's not async but eventProcessors should work.

@marandaneto
Copy link
Contributor

@ueman can we get a code snippet of a simple event processor doing that + SDK init adding the event processor? if that works, we can add it to the migration page, also, there should be a condition to add the event processor or to execute the event processor, it should be only for Android, not iOS

@ueman
Copy link
Collaborator Author

ueman commented May 10, 2021

In Dart there's no Device.Id and the docs https://develop.sentry.dev/sdk/event-payloads/contexts/#device-context also don't list it. Though Android does have it. For Device we would have to add the field.

A snippet for the user is coming.

@marandaneto
Copy link
Contributor

In Dart there's no Device.Id and the docs https://develop.sentry.dev/sdk/event-payloads/contexts/#device-context also don't list it. Though Android does have it. For Device we would have to add the field.

A snippet for the user is coming.

no need, ignore it

@marandaneto
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants