Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Settings.Secure.ANDROID_ID in favor of generated installationId #1455

Merged
merged 3 commits into from
May 3, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented May 3, 2021

📜 Description

Remove Settings.Secure.ANDROID_ID in favor of generated installationId

💡 Motivation and Context

https://docs.sentry.io/product/security/mobile-privacy/
Fixes #1446

💚 How did you test it?

running it, tests always exists for non null user id

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

CHANGELOG.md Outdated Show resolved Hide resolved
@marandaneto
Copy link
Contributor Author

@bruno-garcia a thing to consider here is: Flutter, RN and Cordova won't be able to set a beforeSend and set the previous behavior as this is set on the native layer

@bruno-garcia
Copy link
Member

@bruno-garcia a thing to consider here is: Flutter, RN and Cordova won't be able to set a beforeSend and set the previous behavior as this is set on the native layer

We could possibly have a new option on the native bridge to get back to the old behavior. But ideally we'd drop that on the next major anyway

@marandaneto
Copy link
Contributor Author

@bruno-garcia a thing to consider here is: Flutter, RN and Cordova won't be able to set a beforeSend and set the previous behavior as this is set on the native layer

We could possibly have a new option on the native bridge to get back to the old behavior. But ideally we'd drop that on the next major anyway

@ueman and @jennmueng please create an issue in the RN, Flutter and Cordova repos

@marandaneto marandaneto merged commit 5696370 into main May 3, 2021
@marandaneto marandaneto deleted the remove/ANDROID_ID branch May 3, 2021 14:19
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2021

Fails
🚫 Please consider adding a changelog entry for the next release.
`Instructions and example for changelog`$

Please add an entry to CHANGELOG.md` to the "Unreleased" section under the following heading:

To the changelog entry, please add a link to this PR (consider a more descriptive message):`

- Remove Settings.Secure.ANDROID_ID in favor of generated installationId(#1455)

If none of the above apply, you can opt out by adding _#skip-changelog_ to the PR description.

Generated by 🚫 dangerJS against 14a861c

@bruno-garcia
Copy link
Member

@bruno-garcia a thing to consider here is: Flutter, RN and Cordova won't be able to set a beforeSend and set the previous behavior as this is set on the native layer

We could possibly have a new option on the native bridge to get back to the old behavior. But ideally we'd drop that on the next major anyway

@ueman and @jennmueng please create an issue in the RN, Flutter and Cordova repos

Raised the RN: getsentry/sentry-react-native#1489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate Settings.Secure.ANDROID_ID in favor of generated InstallationId
2 participants