Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reenable windows obfuscation support #2426

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Nov 21, 2024

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against fe4013f

@vaind vaind force-pushed the feat/enable-windows-native branch from 783b497 to 8077563 Compare November 21, 2024 11:11
@vaind vaind force-pushed the feat/enable-windows-native branch from 8077563 to c135c54 Compare November 21, 2024 11:11
@vaind vaind marked this pull request as ready for review November 21, 2024 11:11
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.15%. Comparing base (07cd9e8) to head (fe4013f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2426      +/-   ##
==========================================
+ Coverage   85.09%   85.15%   +0.05%     
==========================================
  Files         257      257              
  Lines        9197     9200       +3     
==========================================
+ Hits         7826     7834       +8     
+ Misses       1371     1366       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@vaind vaind changed the title feat: reenable windows native support feat: reenable windows obfuscation support Nov 21, 2024
Copy link
Contributor

github-actions bot commented Nov 21, 2024

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 522.32 ms 598.80 ms 76.48 ms
Size 6.49 MiB 7.56 MiB 1.07 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
61e71ec 343.94 ms 410.59 ms 66.66 ms
1edf30e 334.00 ms 378.35 ms 44.35 ms
3a43905 334.12 ms 404.02 ms 69.90 ms
6e083bb 327.96 ms 381.39 ms 53.43 ms
daa1b33 366.98 ms 451.59 ms 84.61 ms
dd76eef 461.37 ms 540.55 ms 79.18 ms
c57d3b7 413.56 ms 508.80 ms 95.24 ms
299a3f6 508.79 ms 563.71 ms 54.93 ms
be1723a 453.86 ms 493.64 ms 39.78 ms
0f067d3 359.56 ms 431.28 ms 71.72 ms

App size

Revision Plain With Sentry Diff
61e71ec 6.34 MiB 7.28 MiB 966.26 KiB
1edf30e 5.94 MiB 6.96 MiB 1.02 MiB
3a43905 6.06 MiB 7.03 MiB 996.98 KiB
6e083bb 5.94 MiB 6.97 MiB 1.03 MiB
daa1b33 6.27 MiB 7.20 MiB 956.36 KiB
dd76eef 6.35 MiB 7.40 MiB 1.05 MiB
c57d3b7 6.33 MiB 7.30 MiB 992.08 KiB
299a3f6 6.49 MiB 7.56 MiB 1.07 MiB
be1723a 6.49 MiB 7.56 MiB 1.07 MiB
0f067d3 6.33 MiB 7.30 MiB 992.08 KiB

Previous results on branch: feat/enable-windows-native

Startup times

Revision Plain With Sentry Diff
c135c54 435.51 ms 470.67 ms 35.16 ms

App size

Revision Plain With Sentry Diff
c135c54 6.49 MiB 7.56 MiB 1.07 MiB

Copy link
Contributor

github-actions bot commented Nov 21, 2024

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1246.02 ms 1268.06 ms 22.04 ms
Size 8.38 MiB 9.77 MiB 1.40 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
84bc635 1252.26 ms 1273.96 ms 21.70 ms
464b4d0 1249.02 ms 1261.22 ms 12.20 ms
134c9f8 1284.48 ms 1306.18 ms 21.70 ms
6aab859 1245.14 ms 1247.59 ms 2.45 ms
c9d3212 1231.84 ms 1237.40 ms 5.57 ms
d5f600b 1220.79 ms 1232.93 ms 12.14 ms
8e133ad 1268.19 ms 1277.37 ms 9.18 ms
a758ebd 1256.90 ms 1277.67 ms 20.77 ms
7f14ddd 1247.36 ms 1269.89 ms 22.53 ms
333903e 1251.15 ms 1270.21 ms 19.06 ms

App size

Revision Plain With Sentry Diff
84bc635 8.33 MiB 9.40 MiB 1.07 MiB
464b4d0 8.10 MiB 9.16 MiB 1.07 MiB
134c9f8 8.16 MiB 9.16 MiB 1.01 MiB
6aab859 8.29 MiB 9.36 MiB 1.07 MiB
c9d3212 8.29 MiB 9.39 MiB 1.10 MiB
d5f600b 8.32 MiB 9.38 MiB 1.05 MiB
8e133ad 8.10 MiB 9.16 MiB 1.07 MiB
a758ebd 8.38 MiB 9.75 MiB 1.37 MiB
7f14ddd 8.33 MiB 9.64 MiB 1.31 MiB
333903e 8.10 MiB 9.16 MiB 1.06 MiB

Previous results on branch: feat/enable-windows-native

Startup times

Revision Plain With Sentry Diff
c135c54 1249.76 ms 1274.22 ms 24.46 ms

App size

Revision Plain With Sentry Diff
c135c54 8.38 MiB 9.77 MiB 1.40 MiB

@vaind vaind marked this pull request as draft November 21, 2024 11:50
@vaind vaind marked this pull request as ready for review November 21, 2024 12:34
@vaind vaind merged commit be7a831 into main Nov 21, 2024
136 of 137 checks passed
@vaind vaind deleted the feat/enable-windows-native branch November 21, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants