Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve device info parsing on dart & non-mobile Flutter #2441

Merged
merged 4 commits into from
Nov 22, 2024

Merge branch 'main' into feat/improve-io-contexts

06685ad
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: improve device info parsing on dart & non-mobile Flutter #2441

Merge branch 'main' into feat/improve-io-contexts
06685ad
Select commit
Loading
Failed to load commit list.
GitHub Actions / Analysis of sentry_drift succeeded Nov 22, 2024 in 59s

Package analysis results for sentry_drift

Score

160/160 points
(100.0%)

Supported platforms

  • Flutter
    • android
    • ios
    • windows
    • linux
    • macos
    • web

Details

Follow Dart file conventions (30/30)

✔ 10/10 points: Provide a valid pubspec.yaml

✔ 5/5 points: Provide a valid README.md

✔ 5/5 points: Provide a valid CHANGELOG.md

✔ 10/10 points: Use an OSI-approved license

Detected license: MIT.

Provide documentation (20/20)

✔ 10/10 points: 20% or more of the public API has dartdoc comments

14 out of 19 API elements (73.7 %) have documentation comments.

Some symbols that are missing documentation: sentry_drift, sentry_drift.SentryQueryExecutor.dbNameKey, sentry_drift.SentryQueryExecutor.dbOp, sentry_drift.SentryQueryExecutor.dbSystem, sentry_drift.SentryQueryExecutor.dbSystemKey.

✔ 10/10 points: Package has an example

Platform support (20/20)

✔ 20/20 points: Supports 6 of 6 possible platforms (iOS, Android, Web, Windows, macOS, Linux)

  • ✓ Android

  • ✓ iOS

  • ✓ Windows

  • ✓ Linux

  • ✓ macOS

  • ✓ Web

❌ 0/0 points: WASM compatibility

Package not compatible with runtime wasm

Because:

  • package:sentry_drift/sentry_drift.dart that imports:
  • package:sentry_drift/src/sentry_query_executor.dart that imports:
  • package:sentry_drift/src/sentry_transaction_executor.dart that imports:
  • package:sentry_drift/src/sentry_span_helper.dart that imports:
  • package:sentry/sentry.dart that imports:
  • package:sentry/src/type_check_hint.dart that imports:
  • package:sentry/src/http_client/failed_request_client.dart that imports:
  • package:sentry/src/http_client/sentry_http_client.dart that imports:
  • package:sentry/src/http_client/breadcrumb_client.dart that imports:
  • package:sentry/src/hub_adapter.dart that imports:
  • package:sentry/src/sentry.dart that imports:
  • package:sentry/src/dart_exception_type_identifier.dart that imports:
  • package:sentry/src/dart_exception_type_identifier_io.dart that imports:
  • dart:io

This package is not compatible with runtime wasm, and will not be rewarded full points in a future version of the scoring model.

See https://dart.dev/web/wasm for details.

Pass static analysis (50/50)

✔ 50/50 points: code has no errors, warnings, lints, or formatting issues

Support up-to-date dependencies (40/40)

✔ 10/10 points: All of the package dependencies are supported in the latest version

Package Constraint Compatible Latest
drift ^2.13.0 2.21.0 2.21.0
meta ^1.3.0 1.16.0 1.16.0
sentry 8.11.0-beta.1 8.11.0-beta.1 8.11.0-beta.1
Transitive dependencies
Package Constraint Compatible Latest
async - 2.12.0 2.12.0
collection - 1.19.1 1.19.1
convert - 3.1.2 3.1.2
crypto - 3.0.6 3.0.6
ffi - 2.1.3 2.1.3
fixnum - 1.1.1 1.1.1
http - 1.2.2 1.2.2
http_parser - 4.1.1 4.1.1
path - 1.9.1 1.9.1
source_span - 1.10.0 1.10.0
sprintf - 7.0.0 7.0.0
sqlite3 - 2.4.7 2.4.7
stack_trace - 1.12.0 1.12.0
stream_channel - 2.1.2 2.1.2
string_scanner - 1.4.0 1.4.0
term_glyph - 1.2.1 1.2.1
typed_data - 1.4.0 1.4.0
uuid - 4.5.1 4.5.1
web - 1.1.0 1.1.0

To reproduce run dart pub outdated --no-dev-dependencies --up-to-date --no-dependency-overrides.

✔ 10/10 points: Package supports latest stable Dart and Flutter SDKs

✔ 20/20 points: Compatible with dependency constraint lower bounds

pub downgrade does not expose any static analysis error.

Versions