Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check SentryTracer type in ttfd tracker #2508

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Dec 16, 2024

Fixes integration tests where the app starts to push a route but the test is already done / Sentry is closing

@buenaflor buenaflor requested a review from vaind December 16, 2024 18:11
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (4d046e0) to head (997ae9f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2508      +/-   ##
==========================================
+ Coverage   86.97%   91.52%   +4.55%     
==========================================
  Files         264       87     -177     
  Lines        9388     3044    -6344     
==========================================
- Hits         8165     2786    -5379     
+ Misses       1223      258     -965     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1249.65 ms 1266.20 ms 16.55 ms
Size 8.42 MiB 9.83 MiB 1.40 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
13f8952 1249.98 ms 1278.31 ms 28.33 ms
aa950e9 1275.17 ms 1295.33 ms 20.16 ms
6572f8d 1242.16 ms 1246.63 ms 4.47 ms
895becc 1288.00 ms 1308.63 ms 20.63 ms
1131914 1277.20 ms 1300.20 ms 23.00 ms
2e1e4ae 1254.41 ms 1278.55 ms 24.14 ms
66e0270 1240.67 ms 1270.11 ms 29.43 ms
be8cafe 1239.94 ms 1266.20 ms 26.27 ms
9f9dd52 1364.63 ms 1394.89 ms 30.25 ms
b98109e 1254.19 ms 1279.90 ms 25.71 ms

App size

Revision Plain With Sentry Diff
13f8952 8.38 MiB 9.78 MiB 1.40 MiB
aa950e9 8.16 MiB 9.17 MiB 1.01 MiB
6572f8d 8.29 MiB 9.36 MiB 1.07 MiB
895becc 8.10 MiB 9.18 MiB 1.08 MiB
1131914 8.16 MiB 9.17 MiB 1.01 MiB
2e1e4ae 8.34 MiB 9.65 MiB 1.31 MiB
66e0270 8.33 MiB 9.62 MiB 1.29 MiB
be8cafe 8.33 MiB 9.40 MiB 1.07 MiB
9f9dd52 8.33 MiB 9.63 MiB 1.29 MiB
b98109e 8.10 MiB 9.17 MiB 1.08 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants