Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js): Update docs for custom integrations #10150

Merged
merged 3 commits into from
May 27, 2024
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented May 27, 2024

This updates the JS custom integration docs to show which APIs we support.

@mydea mydea requested review from lforst, Lms24 and andreiborza May 27, 2024 07:52
@mydea mydea self-assigned this May 27, 2024
Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 9:44am

Copy link

codecov bot commented May 27, 2024

Bundle Report

Changes will decrease total bundle size by 12 bytes ⬇️

Bundle name Size Change
sentry-docs-server 7.42MB 3 bytes ⬇️
sentry-docs-edge-server 461.86kB 3 bytes ⬇️
sentry-docs-client 6.18MB 6 bytes ⬇️

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! Should we also document preprocessEvent and afterAllSetup?

(doesn't have to happen in this PR! We can also omit it)

@mydea
Copy link
Member Author

mydea commented May 27, 2024

I decided to keep it simple for now, not showing preprocessEvent and afterAllSetup because it probably should not be used in user-land (we can always add it later if needed).

I decided to keep it simple for now, not showing preprocessEvent and afterAllSetup because it probably should not be used in user-land (we can always add it later if needed).

No strong feelings on this though, also happy to add this too 🤔

@andreiborza
Copy link
Member

I decided to keep it simple for now, not showing preprocessEvent and afterAllSetup because it probably should not be used in user-land (we can always add it later if needed).

I decided to keep it simple for now, not showing preprocessEvent and afterAllSetup because it probably should not be used in user-land (we can always add it later if needed).

No strong feelings on this though, also happy to add this too 🤔

I'm personally interested in afterAllSetup since I'm using it atm :)

@mydea
Copy link
Member Author

mydea commented May 27, 2024

I'm personally interested in afterAllSetup since I'm using it atm :)

haha, good point - I'll simply add all methods then 👍

mydea and others added 2 commits May 27, 2024 11:09
…stom.mdx

Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
@mydea
Copy link
Member Author

mydea commented May 27, 2024

Updated this to now document all methods.

Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mydea mydea merged commit 8c34620 into master May 27, 2024
6 checks passed
@mydea mydea deleted the fn/js-custom-integrations branch May 27, 2024 09:45
matejminar pushed a commit that referenced this pull request Jun 6, 2024

---------

Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
a-hariti pushed a commit that referenced this pull request Jun 8, 2024

---------

Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants