Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Use new scope API #10892

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jul 29, 2024

DESCRIBE YOUR PR

In getsentry/sentry-python#3357, we'll be adding new top-level API to interact with scopes, so that:

  • sentry_sdk.Scope.get_current_scope() becomes sentry_sdk.get_current_scope()
  • sentry_sdk.Scope.get_isolation_scope() becomes sentry_sdk.get_isolation_scope()
  • sentry_sdk.Scope.get_global_scope() becomes sentry_sdk.get_global_scope()

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline: Aug 2
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 11:05am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 11:05am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 11:05am

@sentrivana sentrivana marked this pull request as ready for review July 29, 2024 10:48
@sentrivana sentrivana requested review from sl0thentr0py and a team July 29, 2024 10:48
Copy link

codecov bot commented Jul 29, 2024

Bundle Report

Changes will increase total bundle size by 8.19MB ⬆️

Bundle name Size Change
sentry-docs-server 9.83MB 6 bytes ⬇️
sentry-docs-client 8.19MB 8.19MB ⬆️
sentry-docs-edge-server 259.17kB 3 bytes ⬇️

@sentrivana sentrivana merged commit f6dc946 into master Aug 5, 2024
9 checks passed
@sentrivana sentrivana deleted the ivana/python/update-migration-guide branch August 5, 2024 07:47
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants