-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(angular): Add code snippets for app.config.ts
-based Angular apps
#11356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Lms24
requested review from
a team,
mydea,
AbhiPrasad and
ArthurKnaus
and removed request for
a team
September 13, 2024 13:45
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
AbhiPrasad
approved these changes
Sep 13, 2024
ArthurKnaus
approved these changes
Sep 16, 2024
lizokm
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments, but otherwise this looks great!
docs/platforms/javascript/guides/angular/features/component-tracking.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/guides/angular/features/component-tracking.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/guides/angular/features/component-tracking.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/guides/angular/features/component-tracking.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Liza Mock <liza.mock@sentry.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following getsentry/sentry#77134 in the product, this PR now also adds code snippets for AppConfig-bsaed Angular apps to our Docs.
I opted for displaying the snippets in tabs next to each other (1 tab for
app.config.ts
vsapp.module.ts
).closes #8342