Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Delete inaccurate, confusing block #11357

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

szokeasaurusrex
Copy link
Member

DESCRIBE YOUR PR

The code snippet no longer uses push_scope. This block is incorrect as a result.

Rather than fix the block, I think it makes more sense simply to delete it. I think the page already provides enough context around what we are doing.

IS YOUR CHANGE URGENT?

  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

The code snippet no longer uses `push_scope`. This block is incorrect as a result.

Rather than fix the block, I think it makes more sense simply to delete it. I think the page already provides enough context around what we are doing.
@szokeasaurusrex szokeasaurusrex requested review from sentrivana and a team September 13, 2024 13:50
Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 2:06pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 2:06pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Sep 13, 2024 2:06pm

Copy link

codecov bot commented Sep 13, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.43MB 6 bytes ⬇️
sentry-docs-edge-server-array-push 257.01kB 3 bytes ⬇️
sentry-docs-client-array-push 6.4MB 6 bytes ⬇️

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!!

@lizokm lizokm merged commit f0ea8bc into master Sep 17, 2024
10 checks passed
@lizokm lizokm deleted the szokeasaurusrex-patch-1 branch September 17, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants