Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruct to use the recommended way of using Vue component tracking #11917

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Nov 22, 2024

DESCRIBE YOUR PR

Based on getsentry/sentry-javascript#14265 and getsentry/sentry-javascript#14385 we are updating how users should enable component tracking for Vue and Nuxt.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 8:57am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 8:57am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 8:57am

Copy link

codecov bot commented Nov 22, 2024

Bundle Report

Changes will increase total bundle size by 95.28kB (0.48%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.38MB 95.28kB (0.93%) ⬆️
sentry-docs-client-array-push 9.29MB 6 bytes (-0.0%) ⬇️

});
```

The following hooks are available to track in Vue 3: `['activate', 'create', 'unmount', 'mount', 'update']`
The default set of tracked hooks is `['activate', 'mount', 'update']`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another item in the v9 list to remove update as a hook to track by default, right? No action required, was just remembering that we discussed this

The following hooks are available to track in Vue 3: `['activate', 'create', 'unmount', 'mount', 'update']`

Note, that when specifying `hooks`, we use the simple verb rather than `before` and `-ed` pairs. For example, `unmount` is correct, while `beforeUnmount` and `unmounted` are incorrect.
The following hooks are available to track: `['activate', 'create', 'unmount', 'mount', 'update']`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Iet's also add the hooks tracked by default here

@lforst lforst enabled auto-merge (squash) November 25, 2024 08:38
@lforst lforst merged commit 80e4a25 into master Nov 25, 2024
11 checks passed
@lforst lforst deleted the lforst-vue-component-tracking-deprecations branch November 25, 2024 08:57
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants