Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transports page to Node.JS docs with info about custom Forge transport #3962

Closed
wants to merge 1 commit into from

Conversation

1999
Copy link

@1999 1999 commented Jul 31, 2021

This PR is a follow-up of our discussion here: getsentry/sentry-javascript#3669

image

@vercel
Copy link

vercel bot commented Jul 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/EarWmYj4ZGk759jAKKvrUreU1L2o
✅ Preview: https://sentry-docs-git-fork-1999-dsorin-forge-custom-transport.sentry.dev

@lobsterkatie
Copy link
Member

Hi, @1999. Thanks for working on this project!

I chatted with the team, and we want do to a little structural work before we include third-party integrations. Once we do, it will likely be as a link rather than as a full example, similar to the way we link to community-supported SDKs. The content included in this PR would then be included as part of your README.

(On the topic of your current README, I have one suggestion: You say, "Use it to capture errors and messages from Forge runtime." From reading your transport's code (and given the purpose of transports in general), I'd suggest changing that to, "Use it to send captured errors and messages from Forge runtime.")

I'm sorry - I know you'd talked to Kamil about this already, and he told you to go ahead and make a PR like this one, but we want to start encouraging more folks to contribute transports and integrations, and we decided that including detailed docs about each wasn't going to be scalable. (It also muddies the waters with respect to support responsibility.)

I'm going to close this issue, but please feel free to ping me back with questions.

@1999
Copy link
Author

1999 commented Aug 3, 2021

@lobsterkatie that's fair enough, I'm happy with anything you suggest :) I will keep following the issue you mentioned and once this work is done, I'll add a link to our transport there.

I have one suggestion: You say, "Use it to capture errors and messages from Forge runtime." From reading your transport's code (and given the purpose of transports in general), I'd suggest changing that to, "Use it to send captured errors and messages from Forge runtime.")

That's an excellent suggestion. I will do this today.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants