feat(crons): Ruby docs for auto-instrumentation #8550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@natikgadzhi is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shanamatthews
approved these changes
Nov 22, 2023
|
We've merged the mentioned PR that implement the automatic checkins support, but we have not rolled a release yet. I'll keep an eye on when it goes to GA. |
sl0thentr0py
requested changes
Nov 24, 2023
sl0thentr0py
approved these changes
Nov 24, 2023
|
will merge after release on monday |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a satellite PR to Sentry-Ruby's Crons auto-instrumentation support. We should only merge this when the three PRs below are merged and shipped:
sentry-cron: Addsidekiq-cronpatch for automatic monitoring of jobs listed in the schedule sentry-ruby#2170sentry-scheduler: Crons: addsidekiq-schedulerzero-config monitor check-ins sentry-ruby#2172sentry-croncleanup: (fix) crons: require sidekiq-cron early sentry-ruby#2173/cc @sl0thentr0py
Pre-merge checklist
If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Extra resources