This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
Update: bump sentry sdk to 3.0.3 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
added a commit
that referenced
this pull request
May 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10.
Sample errors captured:
https://sentry.io/share/issue/8f99f27273a641c692a3d269881c55c3/
https://sentry.io/share/issue/4e28dca2bc254e93a4ffc4285e7fec1d/
I'm not an expert with Dotnet ef, but the tests are passing and the sample running :D
About the tests, it seems the script was hardcoded to test the net462 output while the test was targeting net461, by that, no tests were running (at least on my machine).
System.Runtime.InteropServices.RuntimeInformation on the Sample project was targeting the wrong version, thus generating an error when loading the project.
Breaking changes:
Sentry.Protocol and Sentry.PlatformAbstractions are no longer required and the DSN is just a string.