Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing packages to craft file #2615

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Add missing packages to craft file #2615

merged 3 commits into from
Oct 11, 2023

Conversation

jamescrosswell
Copy link
Collaborator

#skip-changelog

Added Sentry.AzureFunctions.Worker and Sentry.OpenTelemetry to .craft.yml so that these get included in the release registry.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging this we need to add these to https://github.com/getsentry/sentry-release-registry/ which requires 1 of a few ppl at Sentry with perm to merge so blocking for now

@bruno-garcia
Copy link
Member

prob best to take this chance and rename AzureFunctions to Azure.Functions and GA it, wdty

@bitsandfoxes
Copy link
Contributor

bitsandfoxes commented Sep 13, 2023

Let's fix #2579, rename it, and then GA this.

@bruno-garcia bruno-garcia self-requested a review September 14, 2023 03:24
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to leave it unblocked

@bruno-garcia
Copy link
Member

image
needs an approval now to let this get merged 🙄

@jamescrosswell
Copy link
Collaborator Author

Merged in the latest changes from main (including those from #2579). So I think we should be good to go now.

Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not! Sec

@bitsandfoxes bitsandfoxes merged commit d8f293e into main Oct 11, 2023
14 checks passed
@bitsandfoxes bitsandfoxes deleted the update-craft-file branch October 11, 2023 15:34
vaind pushed a commit that referenced this pull request Oct 14, 2023
vaind pushed a commit that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants