Removed Scope.Platform as it would never be applied.

CHANGELOG.md

@@ -26,6 +26,7 @@ API Changes:
 - Change `StackFrame`'s `ImageAddress`, `InstructionAddress` and `FunctionId` to `long?`. ([#2691](https://github.com/getsentry/sentry-dotnet/pull/2691))
 - Enable `CaptureFailedRequests` by default ([2688](https://github.com/getsentry/sentry-dotnet/pull/2688))
 - Additional constructors removed from `TransactionTracer`. ([#2694](https://github.com/getsentry/sentry-dotnet/pull/2694))
+- Removed the `Scope.Platform` property as it was never applied ([#2695](https://github.com/getsentry/sentry-dotnet/pull/2695))
 
 ## Unreleased
 

src/Sentry/IEventLike.cs

@@ -50,16 +50,6 @@ public interface IEventLike : IHasTags, IHasExtra
     /// </value>
     User User { get; set; }
 
-    /// <summary>
-    /// The name of the platform.
-    /// </summary>
-    /// <remarks>
-    /// In most cases, the platform will be "csharp". However, it may differ if the event
-    /// was generated from another embeded SDK.  For example, when targeting net6.0-android,
-    /// events generated by the Sentry Android SDK will have the platform "java".
-    /// </remarks>
-    public string? Platform { get; set; }
-
     /// <summary>
     /// The release version of the application.
     /// </summary>

src/Sentry/ITransactionData.cs

@@ -5,4 +5,13 @@ namespace Sentry;
 /// </summary>
 public interface ITransactionData : ISpanData, ITransactionContext, IEventLike
 {
+    /// <summary>
+    /// The name of the platform.
+    /// </summary>
+    /// <remarks>
+    /// In most cases, the platform will be "csharp". However, it may differ if the event
+    /// was generated from another embeded SDK.  For example, when targeting net6.0-android,
+    /// events generated by the Sentry Android SDK will have the platform "java".
+    /// </remarks>
+    public string? Platform { get; set; }
 }

src/Sentry/Internal/Enricher.cs

@@ -54,9 +54,6 @@ public void Apply(IEventLike eventLike)
             eventLike.Sdk.AddPackage("nuget:" + SdkVersion.Instance.Name, SdkVersion.Instance.Version);
         }
 
-        // Platform
-        eventLike.Platform ??= Sentry.Constants.Platform;
-
         // Release
         eventLike.Release ??= _options.SettingLocator.GetRelease();
 

src/Sentry/Scope.cs

@@ -137,9 +137,6 @@ public User User
         }
     }
 
-    /// <inheritdoc />
-    public string? Platform { get; set; }
-
     /// <inheritdoc />
     public string? Release { get; set; }
 
@@ -345,7 +342,6 @@ public void Clear()
         Request = new();
         Contexts.Clear();
         User = new();
-        Platform = default;
         Release = default;
         Distribution = default;
         Environment = default;
@@ -435,7 +431,6 @@ public void Apply(IEventLike other)
         Request.CopyTo(other.Request);
         User.CopyTo(other.User);
 
-        other.Platform ??= Platform;
         other.Release ??= Release;
         other.Distribution ??= Distribution;
         other.Environment ??= Environment;

test/Sentry.Tests/ScopeTests.cs

@@ -624,7 +624,6 @@ public static void ApplyFakeValues(this Scope scope, string salt = "fake")
         scope.Request = new() { Data = $"{salt} request" };
         scope.Contexts.Add($"{salt} context", "{}");
         scope.User = new User() { Username = $"{salt} username" };
-        scope.Platform = $"{salt} platform";
         scope.Release = $"{salt} release";
         scope.Distribution = $"{salt} distribution";
         scope.Environment = $"{salt} environment";
@@ -643,7 +642,6 @@ public static void ShouldBeEquivalentTo(this Scope source, Scope target)
         source.Request.Should().BeEquivalentTo(target.Request);
         source.Contexts.Should().BeEquivalentTo(target.Contexts);
         source.User.Should().BeEquivalentTo(target.User);
-        source.Platform.Should().Be(target.Platform);
         source.Release.Should().Be(target.Release);
         source.Distribution.Should().Be(target.Distribution);
         source.Environment.Should().Be(target.Environment);