Reordered parameters to TransactionContext and SpanContext constructors #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor having default properties
|
bitsandfoxes
reviewed
Oct 9, 2023
bitsandfoxes
approved these changes
Oct 11, 2023
jamescrosswell
changed the title
jamescrosswell
changed the title
vaind
pushed a commit
that referenced
this pull request
Oct 14, 2023
…rs (#2696) * Replaced multiple TransactionContext constructors to a single constructor having default properties * Made most of the SpanContext constructor parameters optional
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidated multiple TransactionContext constructors into a single constructor with default values for most of the arguments... so all the convience of some overloads and all the power of others.
SDK Change Notes
Both the
TransactionContextandSpanContextclasses now have default values for most of the values that can be passed to their constructors, which should mean you no longer need to provide unecessarynullvalues etc. for arguments you don't care about.However in order to make this change, the order of parameters had to be changed so that the non-optional parameters come first in the constructor method signatures. If you're constructing instances of these classes in your own code (which is unlikely), you will need to adjust the order in which you pass parameters to these. See the PR changes for details.