Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build on mac m1 #2702

Merged
merged 1 commit into from
Oct 5, 2023
Merged

fix build on mac m1 #2702

merged 1 commit into from
Oct 5, 2023

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Oct 5, 2023 •
edited
Loading

#skip-changelog

bruno-garcia
bruno-garcia requested changes Oct 5, 2023
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets just go with net8

@vaind
Copy link
Collaborator Author

vaind commented Oct 5, 2023

lets just go with net8

would love to but we need to fix branch 4.0.0 now and we cannot switch to .net 8 before RC2 which fixes build on mac in general (see #2622)

@bruno-garcia bruno-garcia merged commit c420292 into feat/4.0.0 Oct 5, 2023
13 of 14 checks passed
@bruno-garcia bruno-garcia deleted the fix/m1-4.0.0 branch October 5, 2023 19:56
@bruno-garcia
Copy link
Member

got it. I thought that was merged already.

vaind added a commit that referenced this pull request Oct 14, 2023
@vaind
fix build on mac m1 (#2702)
4cb767d
vaind added a commit that referenced this pull request Oct 17, 2023
@bruno-garcia @vaind
@jamescrosswell @bitsandfoxes @dependabot @getsentry-bot @github-actions
build with dotnet 8 sdk (#2622)
1d16e00 
Co-authored-by: Ivan Dlugos <dlugos.ivan@gmail.com>
Co-authored-by: James Crosswell <jamescrosswell@users.noreply.github.com>
Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
Co-authored-by: Stefan Jandl <reg@bitfox.at>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: getsentry-bot <bot@sentry.io>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
fix build on mac m1 (#2702)
Fix: Scope not being applied to OpenTelemetry spans in ASP.NET Core (#2690)
This was referenced Nov 16, 2023
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@bitsandfoxes bitsandfoxes Awaiting requested review from bitsandfoxes

@jamescrosswell jamescrosswell Awaiting requested review from jamescrosswell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaind @bruno-garcia