Consistent names for Transactions representing ASP.NET Core routes

CHANGELOG.md

@@ -84,6 +84,7 @@ without native/platform specific bindings and SDKs. See [this ticket for more de
   - When compiling AOT, Sentry isn't able to automatically register an unhandled exception handler in WinUI applications, since that also relies on reflection. If you're using Sentry with a WinUI application and you want to use AOT compilation, you'll need to take care of registering the unhandled event handler yourself. TODO *** Fill in the gaps here when https://github.com/getsentry/sentry-dotnet/issues/2778 has been completed ***
   - ([#2732](https://github.com/getsentry/sentry-dotnet/pull/2732)), ([#2793](https://github.com/getsentry/sentry-dotnet/pull/2793))
 - The TracePropagationTarget class has been removed. Use the SubstringOrRegexPattern class instead. ([#2763](https://github.com/getsentry/sentry-dotnet/pull/2763))
+- Transaction names for ASP.NET Core are now consistently named `HTTP-VERB /path` (e.g. `GET /home`). Previously the leading forward slash might not have been present for some endpoints ([#2808](https://github.com/getsentry/sentry-dotnet/pull/2808))
 
 #### Sentry.Google.Cloud.Functions
 

src/Sentry.AspNetCore/RouteUtils.cs

@@ -35,7 +35,9 @@ internal static class RouteUtils
             builder.Append(routePattern);
         }
 
-        return builder.ToString();
+        // Force a leading slash (if there isn't already one present)
+        var url = builder.ToString();
+        return url.Length >0 && url[0] == '/' ? url : $"/{url}";
     }
 
     // Internal for testing.

test/Sentry.AspNetCore.Tests/RouteUtilsTests.cs

@@ -28,13 +28,13 @@ private static void AddRouteValuesIfNotNull(RouteValueDictionary route, string k
     }
 
     [Theory]
-    [InlineData("{area=MyArea}/{controller=Home}/{action=Index}/{id?}", "myPath/theArea/house/about/{id?}", "house", "about", "theArea")]
-    [InlineData("{area=MyArea}/{controller=Home}/{action=Index}/{id?}", "myPath/{area=MyArea}/house/about/{id?}", "house", "about", null)]
-    [InlineData("{area=}/{controller=}/{action=}/{id?}", "myPath/{area=}/{controller=}/{action=}/{id?}", "house", "about", "theArea")]
-    [InlineData("{controller=Home}/{action=Index}/{id?}", "myPath/house/about/{id?}", "house", "about", null)]
-    [InlineData("{controller=Home}/{action=Index}", "myPath/house/about", "house", "about", null)]
-    [InlineData("{controller=Home}/{id?}", "myPath/house/{id?}", "house", "about", null)]
-    [InlineData("{action=Index}/{id?}", "myPath/about/{id?}", null, "about", null)]
+    [InlineData("{area=MyArea}/{controller=Home}/{action=Index}/{id?}", "/myPath/theArea/house/about/{id?}", "house", "about", "theArea")]
+    [InlineData("{area=MyArea}/{controller=Home}/{action=Index}/{id?}", "/myPath/{area=MyArea}/house/about/{id?}", "house", "about", null)]
+    [InlineData("{area=}/{controller=}/{action=}/{id?}", "/myPath/{area=}/{controller=}/{action=}/{id?}", "house", "about", "theArea")]
+    [InlineData("{controller=Home}/{action=Index}/{id?}", "/myPath/house/about/{id?}", "house", "about", null)]
+    [InlineData("{controller=Home}/{action=Index}", "/myPath/house/about", "house", "about", null)]
+    [InlineData("{controller=Home}/{id?}", "/myPath/house/{id?}", "house", "about", null)]
+    [InlineData("{action=Index}/{id?}", "/myPath/about/{id?}", null, "about", null)]
     public void NewRouteFormat_MvcRouteWithPathBase_ParsedParameters(string routeInput, string expectedOutput, string controller, string action, string area)
     {
         // Arrange
@@ -48,14 +48,14 @@ public void NewRouteFormat_MvcRouteWithPathBase_ParsedParameters(string routeInp
     }
 
     [Theory]
-    [InlineData("{area=MyArea}/{controller=Home}/{action=Index}/{id?}", "theArea/house/about/{id?}", "house", "about", "theArea", null)]
-    [InlineData("{area=MyArea}/{controller=Home}/{action=Index}/{id?}", "{area=MyArea}/house/about/{id?}", "house", "about", null, null)]
-    [InlineData("{area=}/{controller=}/{action=}/{id?}", "{area=}/{controller=}/{action=}/{id?}", "house", "about", "theArea", null)]
-    [InlineData("{controller=Home}/{action=Index}/{id?}", "house/about/{id?}", "house", "about", null, null)]
-    [InlineData("{controller=Home}/{action=Index}", "house/about", "house", "about", null, null)]
-    [InlineData("{controller=Home}/{id?}", "house/{id?}", "house", "about", null, null)]
-    [InlineData("{action=Index}/{id?}", "about/{id?}", null, "about", null, null)]
-    [InlineData("v{version:apiVersion}/Target", "v1.1/Target", null, "about", null, "1.1")]
+    [InlineData("{area=MyArea}/{controller=Home}/{action=Index}/{id?}", "/theArea/house/about/{id?}", "house", "about", "theArea", null)]
+    [InlineData("{area=MyArea}/{controller=Home}/{action=Index}/{id?}", "/{area=MyArea}/house/about/{id?}", "house", "about", null, null)]
+    [InlineData("{area=}/{controller=}/{action=}/{id?}", "/{area=}/{controller=}/{action=}/{id?}", "house", "about", "theArea", null)]
+    [InlineData("{controller=Home}/{action=Index}/{id?}", "/house/about/{id?}", "house", "about", null, null)]
+    [InlineData("{controller=Home}/{action=Index}", "/house/about", "house", "about", null, null)]
+    [InlineData("{controller=Home}/{id?}", "/house/{id?}", "house", "about", null, null)]
+    [InlineData("{action=Index}/{id?}", "/about/{id?}", null, "about", null, null)]
+    [InlineData("v{version:apiVersion}/Target", "/v1.1/Target", null, "about", null, "1.1")]
     public void NewRouteFormat_MvcRouteWithoutPathBase_ParsedParameters(string routeInput, string expectedOutput, string controller, string action, string area, string version)
     {
         // Arrange
@@ -69,9 +69,9 @@ public void NewRouteFormat_MvcRouteWithoutPathBase_ParsedParameters(string route
     }
 
     [Theory]
-    [InlineData("myPath/some/Path", "/myPath", "some/Path")]
-    [InlineData("some/Path", null, "some/Path")]
-    [InlineData("api/health", "/api", "/health")]
+    [InlineData("/myPath/some/Path", "/myPath", "some/Path")]
+    [InlineData("/some/Path", null, "some/Path")]
+    [InlineData("/api/health", "/api", "/health")]
     [InlineData(null, null, "")]
     [InlineData(null, null, null)]
     public void NewRouteFormat_WithPathBase_MatchesExpectedRoute(string expectedRoute, string pathBase, string rawRoute)

test/Sentry.AspNetCore.Tests/SentryTracingMiddlewareTests.cs

@@ -155,6 +155,48 @@ public async Task Transaction_is_started_automatically_from_incoming_trace_heade
         );
     }
 
+    [Fact]
+    public async Task Transaction_name_includes_slash_prefix()
+    {
+        // Arrange
+        var sentryClient = Substitute.For<ISentryClient>();
+
+        var hub = new Hub(new SentryOptions { Dsn = ValidDsn, TracesSampleRate = 1 }, sentryClient);
+
+        var server = new TestServer(new WebHostBuilder()
+            .UseDefaultServiceProvider(di => di.EnableValidation())
+            .UseSentry()
+            .ConfigureServices(services =>
+            {
+                services.AddRouting();
+
+                services.RemoveAll(typeof(Func<IHub>));
+                services.AddSingleton<Func<IHub>>(() => hub);
+            })
+            .Configure(app =>
+            {
+                app.UseRouting();
+
+                app.UseEndpoints(routes => routes.Map("foo", _ => Task.CompletedTask));
+            }));
+
+        var client = server.CreateClient();
+        Transaction transaction = null;
+        sentryClient.CaptureTransaction(
+            Arg.Do<Transaction>(t => transaction = t),
+            Arg.Any<Hint>()
+            );
+
+        // Act
+        using var request = new HttpRequestMessage(HttpMethod.Get, "foo");
+
+        await client.SendAsync(request);
+
+        // Assert
+        transaction.Should().NotBeNull();
+        transaction.Name.Should().Be("GET /foo");
+    }
+
     [Theory]
     [InlineData(true)]
     [InlineData(false)]

test/Sentry.AspNetCore.Tests/WebIntegrationTests.Versioning.verified.txt

@@ -3,7 +3,7 @@
   Payloads: [
     {
       Source: {
-        Name: GET v1.1/Target,
+        Name: GET /v1.1/Target,
         NameSource: Route,
         Platform: csharp,
         Operation: http.server,