Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DisabledHub.StartTransaction now returns a NoOpTransaction #3574

Closed
wants to merge 2 commits into from
Closed

DisabledHub.StartTransaction now returns a NoOpTransaction #3574

wants to merge 2 commits into from

Conversation

jamescrosswell
Copy link
Collaborator

Resolves #829

@jamescrosswell jamescrosswell changed the base branch from main to version-5.0.0 August 28, 2024 02:52
@jamescrosswell jamescrosswell self-assigned this Aug 28, 2024
bitsandfoxes
bitsandfoxes approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, yes! But why do we need to put that on the 5.0 branch? Because it's functionally a breaking change? Even tho nothing gets sent either way?

@jamescrosswell
Copy link
Collaborator Author

But why do we need to put that on the 5.0 branch?

I can't see any good reason. I'll cherry pick it out into a new branch targeting main instead.

@jamescrosswell jamescrosswell mentioned this pull request Aug 30, 2024
Merged
@jamescrosswell
Copy link
Collaborator Author

Superceded by #3581

@jamescrosswell jamescrosswell deleted the disabledhub-nooptransaction branch October 9, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitsandfoxes bitsandfoxes bitsandfoxes approved these changes

Assignees

@jamescrosswell jamescrosswell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DisabledTransaction or DisabledSpan if SDK is disabled, eg empty DSN
2 participants
@jamescrosswell @bitsandfoxes