feat: Update to JavaScript SDKs v8.0.0-beta.5 (#896)

getsentry · Apr 30, 2024 · dd552c6 · dd552c6
1 parent 6f6b456
commit dd552c6
Show file tree

Hide file tree

Showing 5 changed files with 125 additions and 177 deletions.
diff --git a/package.json b/package.json
@@ -56,18 +56,18 @@
     "e2e": "xvfb-maybe vitest run --root=./test/e2e --silent=false --disable-console-intercept"
   },
   "dependencies": {
-    "@sentry/browser": "8.0.0-beta.4",
-    "@sentry/core": "8.0.0-beta.4",
-    "@sentry/node": "8.0.0-beta.4",
-    "@sentry/types": "8.0.0-beta.4",
-    "@sentry/utils": "8.0.0-beta.4",
+    "@sentry/browser": "8.0.0-beta.5",
+    "@sentry/core": "8.0.0-beta.5",
+    "@sentry/node": "8.0.0-beta.5",
+    "@sentry/types": "8.0.0-beta.5",
+    "@sentry/utils": "8.0.0-beta.5",
     "deepmerge": "4.3.1"
   },
   "devDependencies": {
     "@rollup/plugin-node-resolve": "^15.2.3",
     "@rollup/plugin-typescript": "^11.1.6",
-    "@sentry-internal/eslint-config-sdk": "8.0.0-beta.4",
-    "@sentry-internal/typescript": "8.0.0-beta.4",
+    "@sentry-internal/eslint-config-sdk": "8.0.0-beta.5",
+    "@sentry-internal/typescript": "8.0.0-beta.5",
     "@types/busboy": "^0.2.3",
     "@types/form-data": "^2.5.0",
     "@types/koa": "^2.0.52",

diff --git a/src/renderer/sdk.ts b/src/renderer/sdk.ts
@@ -44,7 +44,7 @@ interface ElectronRendererOptions extends BrowserOptions {
 export function init<O extends ElectronRendererOptions>(
   options: ElectronRendererOptions & O = {} as ElectronRendererOptions & O,
   // This parameter name ensures that TypeScript error messages contain a hint for fixing SDK version mismatches
-  originalInit: (if_you_get_a_typescript_error_ensure_sdks_use_version_v8_0_0_beta_4: O) => void = browserInit,
+  originalInit: (if_you_get_a_typescript_error_ensure_sdks_use_version_v8_0_0_beta_5: O) => void = browserInit,
 ): void {
   // Ensure the browser SDK is only init'ed once.
   if (window?.__SENTRY__RENDERER_INIT__) {

diff --git a/test/e2e/index.test.ts b/test/e2e/index.test.ts
@@ -17,7 +17,7 @@ function hookTestFailure() {
   }
 }
 
-describe('E2E Tests', () => {
+describe('E2E Tests', async () => {
   const testServer = new TestServer();
 
   beforeAll(() => {
@@ -29,12 +29,14 @@ describe('E2E Tests', () => {
   });
 
   for (const electronVersion of getElectronTestVersions()) {
+    console.log(`Downloading Electron v${electronVersion}...`);
+    const electronPath = await downloadElectron(electronVersion);
+    console.log('Downloading complete!');
+
     describe(`Electron v${electronVersion}`, () => {
       let testContext: TestContext | undefined;
-      const electronPath = downloadElectron(electronVersion);
 
       beforeEach(async () => {
-        await electronPath;
         testServer.clearEvents();
         clearTestLog();
       }, 60_000);

diff --git a/test/e2e/vitest.config.mts b/test/e2e/vitest.config.mts
@@ -3,9 +3,9 @@ import { defineConfig } from 'vitest/config';
 export default defineConfig({
   test: {
     include: ['./**/*.test.ts'],
-    retry: process.env.GITHUB_ACTIONS ? 3 : 0,
+    retry: process.env.CI ? 3 : 0,
     disableConsoleIntercept: true,
     silent: false,
-    reporters: process.env.GITHUB_ACTIONS || process.env.DEBUG ? ['basic', 'github-actions'] : ['verbose'],
+    reporters: process.env.CI || process.env.DEBUG ? ['verbose', 'github-actions'] : ['verbose'],
   },
 });