Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Back to testing on ubuntu-latest #1056

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Jan 13, 2025

In a recent PR I had to pin to ubuntu-22.04 because latest didn't support Electrons sandbox in it's default configuration.

This PR disables the sandbox for the Linux tests and reverts to ubuntu-latest. This means we do not test sandbox functionality on Linux but we test other platforms and Electron has extensive tests to cover sandbox behaviour.

@timfish timfish force-pushed the test/ubuntu-latest branch from 0d9368e to be97690 Compare January 14, 2025 11:12
@timfish
Copy link
Collaborator Author

timfish commented Jan 14, 2025

@mydea Sorry, can you change the merge conditions back to check unbuntu-latest?

@timfish timfish marked this pull request as ready for review January 15, 2025 09:58
@timfish timfish requested a review from chargome January 15, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant