Add new client error exception #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not change anything in the logs. Should the logging be changed to match the correct message response coming from client error module? |
whatyouhide
changed the title
whatyouhide
reviewed
Jul 1, 2024
savhappy
force-pushed
the
sav/add-rate-limit-exception
branch
3 times, most recently
from
2d8a9dc to
d06ff76
Compare
whatyouhide
reviewed
Jul 3, 2024
lib/sentry.ex
Outdated
Comment on lines
220
to
223
| @typedoc """ | ||
| An error that is returned from Sentry Client. | ||
| """ | ||
| @type error :: ClientError.t() |
There was a problem hiding this comment.
I’m thinking we don't need to introduce this for now since ClientError is public, no?
There was a problem hiding this comment.
I was thinking preemptive in case we introduce more error types but removed this. You're right, it's redundant.
savhappy
force-pushed
the
sav/add-rate-limit-exception
branch
from
018ee5c to
6aa7c97
Compare
whatyouhide
approved these changes
Jul 3, 2024
|
Yeeehaaaw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-add client error module to handle Sentry client errors